From: Fengguang Wu <fengguang.wu@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: sound/pci/hda/hda_codec.c:3433 snd_hda_codec_write_cache() error: we previously assumed 'c' could be null (see line 3430)
Date: Sat, 12 Jan 2013 10:14:22 +0800 [thread overview]
Message-ID: <20130112021422.GB6150@localhost> (raw)
In-Reply-To: <50f05d4a.7Hp1BArd1hLUlQ5B%yuanhan.liu@linux.intel.com>
Hi Takashi,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-unstable.git master
head: 02e5aa7b459f69538d4ec88658d064816a7692d6
commit: 95836563e7f636fc57732f5e687ca2f170eb674f ALSA: hda - Introduce cache & flush cmd / amp writes
date: 33 hours ago
sound/pci/hda/hda_codec.c:3433 snd_hda_codec_write_cache() error: we previously assumed 'c' could be null (see line 3430)
vim +/c +3433 sound/pci/hda/hda_codec.c
aa2936f5 Takashi Iwai 2009-05-26 3424 /* parm may contain the verb stuff for get/set amp */
aa2936f5 Takashi Iwai 2009-05-26 3425 verb = verb | (parm >> 8);
aa2936f5 Takashi Iwai 2009-05-26 3426 parm &= 0xff;
aa2936f5 Takashi Iwai 2009-05-26 3427 key = build_cmd_cache_key(nid, verb);
aa2936f5 Takashi Iwai 2009-05-26 3428 mutex_lock(&codec->bus->cmd_mutex);
aa2936f5 Takashi Iwai 2009-05-26 3429 c = get_alloc_hash(&codec->cmd_cache, key);
aa2936f5 Takashi Iwai 2009-05-26 @3430 if (c)
aa2936f5 Takashi Iwai 2009-05-26 3431 c->val = parm;
95836563 Takashi Iwai 2012-12-13 3432 if (codec->cached_write)
95836563 Takashi Iwai 2012-12-13 @3433 c->dirty = 1;
aa2936f5 Takashi Iwai 2009-05-26 3434 mutex_unlock(&codec->bus->cmd_mutex);
aa2936f5 Takashi Iwai 2009-05-26 3435 return 0;
b3ac5636 Takashi Iwai 2007-08-10 3436 }
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation
parent reply other threads:[~2013-01-12 2:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <50f05d4a.7Hp1BArd1hLUlQ5B%yuanhan.liu@linux.intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130112021422.GB6150@localhost \
--to=fengguang.wu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.