From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.17.10]:60751 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754406Ab3ALVMl (ORCPT ); Sat, 12 Jan 2013 16:12:41 -0500 From: Arnd Bergmann To: Thierry Reding Subject: Re: [PATCH 10/14] PCI: tegra: Move PCIe driver to drivers/pci/host Date: Sat, 12 Jan 2013 21:12:25 +0000 Cc: Stephen Warren , linux-tegra@vger.kernel.org, Grant Likely , Rob Herring , Russell King , Bjorn Helgaas , Andrew Murray , Jason Gunthorpe , Thomas Petazzoni , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org References: <1357764194-12677-1-git-send-email-thierry.reding@avionic-design.de> <20130111154516.GA25335@avionic-0098.adnet.avionic-design.de> <20130112123640.GA22505@avionic-0098.adnet.avionic-design.de> In-Reply-To: <20130112123640.GA22505@avionic-0098.adnet.avionic-design.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Message-Id: <201301122112.25772.arnd@arndb.de> Sender: linux-pci-owner@vger.kernel.org List-ID: On Saturday 12 January 2013, Thierry Reding wrote: > > I already hinted at that in one of the other subthreads. Having such a > > multiplex would also allow the driver to be built as a module. I had > > already thought about this when I was working on an earlier version of > > these patches. Basically these would be two ops attached to the host > > bridge, and the generic arch_setup_msi_irq() could then look that up > > given the struct pci_dev that is passed to it and call this new per- > > host bridge .setup_msi_irq(). > > struct pci_ops looks like a good place to put these. They'll be > available from each struct pci_bus, so should be easy to call from > arch_setup_msi_irq(). > > Any objections? > struct pci_ops has a long history of being specifically about config space read/write operations, so on the one hand it does not feel like the right place to put interrupt specific operations, but on the other hand, the name sounds appropriate and I cannot think of any other place to put this, so it's fine with me. The only alternative I can think of is to introduce a new structure next to it in struct pci_bus, but that feels a bit pointless. Maybe Bjorn has a preference one way or the other. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sat, 12 Jan 2013 21:12:25 +0000 Subject: [PATCH 10/14] PCI: tegra: Move PCIe driver to drivers/pci/host In-Reply-To: <20130112123640.GA22505@avionic-0098.adnet.avionic-design.de> References: <1357764194-12677-1-git-send-email-thierry.reding@avionic-design.de> <20130111154516.GA25335@avionic-0098.adnet.avionic-design.de> <20130112123640.GA22505@avionic-0098.adnet.avionic-design.de> Message-ID: <201301122112.25772.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday 12 January 2013, Thierry Reding wrote: > > I already hinted at that in one of the other subthreads. Having such a > > multiplex would also allow the driver to be built as a module. I had > > already thought about this when I was working on an earlier version of > > these patches. Basically these would be two ops attached to the host > > bridge, and the generic arch_setup_msi_irq() could then look that up > > given the struct pci_dev that is passed to it and call this new per- > > host bridge .setup_msi_irq(). > > struct pci_ops looks like a good place to put these. They'll be > available from each struct pci_bus, so should be easy to call from > arch_setup_msi_irq(). > > Any objections? > struct pci_ops has a long history of being specifically about config space read/write operations, so on the one hand it does not feel like the right place to put interrupt specific operations, but on the other hand, the name sounds appropriate and I cannot think of any other place to put this, so it's fine with me. The only alternative I can think of is to introduce a new structure next to it in struct pci_bus, but that feels a bit pointless. Maybe Bjorn has a preference one way or the other. Arnd