diff for duplicates of <20130114091526.GA23333@arm.com> diff --git a/a/1.txt b/N1/1.txt index e00e457..aa7e79c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,20 +3,20 @@ On Thu, Dec 20, 2012 at 08:25:00AM +0000, Thierry Reding wrote: > [...] > > diff --git a/drivers/of/address.c b/drivers/of/address.c > [...] -> > + start = of_get_property(node, "ranges", &rlen); -> > + if (start == NULL) -> > + return NULL; +> > +=09start =3D of_get_property(node, "ranges", &rlen); +> > +=09if (start =3D=3D NULL) +> > +=09=09return NULL; > > + -> > + end = start + rlen; -> +> > +=09end =3D start + rlen; +>=20 > I'm currently rewriting large parts of the Tegra PCIe controller driver > and I'm trying to use this new API. This seems to work fine, except that > I think this line needs to be: -> -> end = start + rlen / sizeof(__be32); -> +>=20 +> =09end =3D start + rlen / sizeof(__be32); +>=20 > Otherwise we'll try to process 4 times as many ranges as there are. -> +>=20 > Thierry Good catch. Thanks for taking this on. diff --git a/a/content_digest b/N1/content_digest index 2f55137..40e464c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,15 +4,13 @@ "Subject\0Re: [PATCH] pci: Provide support for parsing PCI DT ranges property\0" "Date\0Mon, 14 Jan 2013 09:15:26 +0000\0" "To\0Thierry Reding <thierry.reding@avionic-design.de>\0" - "Cc\0linux-pci@vger.kernel.org <linux-pci@vger.kernel.org>" - Grant Likely <grant.likely@secretlab.ca> - Michal Simek <monstr@monstr.eu> - Rob Herring <robherring2@gmail.com> + "Cc\0Michal Simek <monstr@monstr.eu>" + linux-pci@vger.kernel.org <linux-pci@vger.kernel.org> devicetree-discuss <devicetree-discuss@lists.ozlabs.org> + Liviu Dudau <Liviu.Dudau@arm.com> rob.herring@calxeda.com <rob.herring@calxeda.com> - linuxppc-dev <linuxppc-dev@lists.ozlabs.org> - Benjamin Herrenschmidt <benh@kernel.crashing.org> - " Liviu Dudau <Liviu.Dudau@arm.com>\0" + Rob Herring <robherring2@gmail.com> + " linuxppc-dev <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On Thu, Dec 20, 2012 at 08:25:00AM +0000, Thierry Reding wrote:\n" @@ -20,24 +18,24 @@ "> [...]\n" "> > diff --git a/drivers/of/address.c b/drivers/of/address.c\n" "> [...]\n" - "> > +\tstart = of_get_property(node, \"ranges\", &rlen);\n" - "> > +\tif (start == NULL)\n" - "> > +\t\treturn NULL;\n" + "> > +=09start =3D of_get_property(node, \"ranges\", &rlen);\n" + "> > +=09if (start =3D=3D NULL)\n" + "> > +=09=09return NULL;\n" "> > +\n" - "> > +\tend = start + rlen;\n" - "> \n" + "> > +=09end =3D start + rlen;\n" + ">=20\n" "> I'm currently rewriting large parts of the Tegra PCIe controller driver\n" "> and I'm trying to use this new API. This seems to work fine, except that\n" "> I think this line needs to be:\n" - "> \n" - "> \tend = start + rlen / sizeof(__be32);\n" - "> \n" + ">=20\n" + "> =09end =3D start + rlen / sizeof(__be32);\n" + ">=20\n" "> Otherwise we'll try to process 4 times as many ranges as there are.\n" - "> \n" + ">=20\n" "> Thierry\n" "\n" "Good catch. Thanks for taking this on.\n" "\n" Andrew Murray -c43da0251a6fd4c9167e923e012621a63377033fa25e110b91bc18c0ea9d9aad +60173670d2c79509bcdf60a121d742693d54ea5a11b13de16ad566d55b053932
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.