From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756874Ab3ANPcH (ORCPT ); Mon, 14 Jan 2013 10:32:07 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:18893 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756297Ab3ANPcF (ORCPT ); Mon, 14 Jan 2013 10:32:05 -0500 Date: Mon, 14 Jan 2013 10:31:57 -0500 From: Konrad Rzeszutek Wilk To: Matt Wilson Cc: stable@vger.kernel.org, Ian Campbell , Annie Li , xen-devel@lists.xen.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] xen/grant-table: correctly initialize grant table version 1 Message-ID: <20130114153157.GF1156@phenom.dumpdata.com> References: <1355997710.26722.12.camel@zakaz.uk.xensource.com> <1357470882-17345-1-git-send-email-msw@amazon.com> <20130111213550.GA31149@phenom.dumpdata.com> <20130114092936.GB15043@u109add4315675089e695.ant.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130114092936.GB15043@u109add4315675089e695.ant.amazon.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 14, 2013 at 10:29:41AM +0100, Matt Wilson wrote: > On Fri, Jan 11, 2013 at 04:35:50PM -0500, Konrad Rzeszutek Wilk wrote: > > > > With this patch I get: > > > > [ 2.555087] GHES: HEST is not enabled! > > [ 2.560522] ioatdma: Intel(R) QuickData Technology Driver 4.00 > > [ 2.569651] ------------[ cut here ]------------ > > [ 2.570529] kernel BUG at /home/konrad/linux/drivers/xen/grant-table.c:1175! > > You dropped part of a hunk when you applied the patch: > > @@ -1127,17 +1128,17 @@ static void gnttab_request_version(void) > panic("we need grant tables version 2, but only version 1 is a > } else { > grant_table_version = 1; > + grefs_per_grant_frame = PAGE_SIZE / sizeof(struct grant_entry_ > gnttab_interface = &gnttab_v1_ops; > } > printk(KERN_INFO "Grant tables using version %d layout.\n", > grant_table_version); > } > > I can rebase to v3.8-rc3 if that would help. Yes pls. > > Matt