All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH 1/3] mke2fs: indicate bigalloc feature explicity when cluster-size is enabled
Date: Mon, 14 Jan 2013 15:28:00 -0500	[thread overview]
Message-ID: <20130114202800.GA8049@thunk.org> (raw)
In-Reply-To: <1358068095-9034-1-git-send-email-wenqing.lz@taobao.com>

On Sun, Jan 13, 2013 at 05:08:13PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
> 
> When cluster-size is enabled without bigalloc feature, mke2fs will ignore this
> argument silently.  But user might think bigalloc feature has been enabled
> unless they use 'stats' command to check it in debugfs.  So now we ask user
> to set bigalloc feature explicity when cluster-size is enabled.  This can
> make sure that users understand what they are doing because bigalloc might
> impact the performance for some workloads.
> 
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>

Thanks, applied.

						- Ted

      parent reply	other threads:[~2013-01-14 20:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13  9:08 [PATCH 1/3] mke2fs: indicate bigalloc feature explicity when cluster-size is enabled Zheng Liu
2013-01-13  9:08 ` [PATCH 2/3] mke2fs: reduce the range of cluster-size Zheng Liu
2013-01-14 17:41   ` Andreas Dilger
2013-01-14 21:03   ` Theodore Ts'o
2013-01-14 21:07     ` Andreas Dilger
2013-01-14 21:10       ` Theodore Ts'o
2013-01-15  0:37         ` [PATCH 1/5] mke2fs: enforce that the cluster size must be less that the block size Theodore Ts'o
2013-01-15  0:37           ` [PATCH 2/5] mke2fs: the -g option will now specify the clusters per block group Theodore Ts'o
2013-01-15 15:10             ` Eric Sandeen
2013-01-15 19:05               ` Theodore Ts'o
2013-01-15 15:22             ` Zheng Liu
2013-01-15  0:37           ` [PATCH 3/5] libe2p: teach parse_num_blocks2() to return bytes if log_block_size < 0 Theodore Ts'o
2013-01-15 15:23             ` Zheng Liu
2013-01-15  0:37           ` [PATCH 4/5] mke2fs: teach mke2fs to understand -b 4k and -C 256M Theodore Ts'o
2013-01-15 15:11             ` Eric Sandeen
2013-01-15 15:13               ` Eric Sandeen
2013-01-15 15:24             ` Zheng Liu
2013-01-15  0:37           ` [PATCH 5/5] libext2fs: avoid 32-bit overflow in ext2fs_initialize with a 512M cluster size Theodore Ts'o
2013-01-15 15:33             ` Zheng Liu
2013-01-15 15:36               ` Zheng Liu
2013-01-15 19:10               ` Theodore Ts'o
2013-01-16  1:49                 ` Zheng Liu
2013-01-15  0:41           ` [PATCH 1/5] mke2fs: enforce that the cluster size must be less that the block size Theodore Ts'o
2013-01-15 15:22             ` Zheng Liu
2013-01-13  9:08 ` [PATCH 3/3] mke2fs: document bigalloc and cluster-size Zheng Liu
2013-01-15  3:10   ` Theodore Ts'o
2013-01-15 19:12     ` Theodore Ts'o
2013-01-15 19:46       ` Phillip Susi
2013-01-15 19:57         ` Theodore Ts'o
2013-01-15 20:38           ` Phillip Susi
2013-01-15 22:28             ` Theodore Ts'o
2013-01-14 20:28 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130114202800.GA8049@thunk.org \
    --to=tytso@mit.edu \
    --cc=gnehzuil.liu@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=wenqing.lz@taobao.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.