From: Cong Ding <dinggnu@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: David Airlie <airlied@linux.ie>, Ben Skeggs <bskeggs@redhat.com>,
Dave Airlie <airlied@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check
Date: Tue, 15 Jan 2013 11:14:52 +0000 [thread overview]
Message-ID: <20130115111451.GB27222@gmail.com> (raw)
In-Reply-To: <9706.1358246363@warthog.procyon.org.uk>
On Tue, Jan 15, 2013 at 10:39:23AM +0000, David Howells wrote:
> Cong Ding <dinggnu@gmail.com> wrote:
>
> > the variable sender is dereferenced in line 190, so it is no reason to check
> > null again in line 198.
>
> Did you mean "The variable 'chan'"?
sorry, my fault. so should I send a new version to correct the typo?
- cong
next prev parent reply other threads:[~2013-01-15 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 0:38 [PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check Cong Ding
2013-01-15 10:39 ` David Howells
2013-01-15 11:14 ` Cong Ding [this message]
2013-01-15 17:00 ` David Howells
2013-01-15 17:19 ` [PATCH v2] " Cong Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115111451.GB27222@gmail.com \
--to=dinggnu@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=dhowells@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.