From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 00/13] The final nail in AGP on GEN6+ Date: Tue, 15 Jan 2013 19:01:44 -0800 Message-ID: <20130115190144.00004edb@unknown> References: <1358285181-2128-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id B4ECBE6129 for ; Tue, 15 Jan 2013 19:03:22 -0800 (PST) Received: from unknown (c-24-21-100-90.hsd1.or.comcast.net [24.21.100.90]) by shiva.chad-versace.us (Postfix) with ESMTPSA id A949C88100 for ; Wed, 16 Jan 2013 03:04:37 +0000 (UTC) In-Reply-To: <1358285181-2128-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 15 Jan 2013 13:26:08 -0800 Ben Widawsky wrote: > 1-3: Pave the way to use a new struct i915_gtt > 4: Create the new structure > 5-13: Move all AGP bridge data to new structure. Killing off things > where possible. > > I am happy that yet again this series results in a net decrease of > code (even though we have to duplicate a couple of struct fields). > > It's now even more trivial than before to even cut out the > intel-gtt.ko requirement. > > I have some future things relying on the i915_gtt structure, so > patches 1-4 are important to me. Small heads up to potential reviewers: Daniel found a couple of bugs in patches 6 and 7 where I am not initializing various gtt information we need in pre-GEN6 case. I've addressed these and will resend them in the future. Also, patch 10 needs a better commit message. It was originally two distinct commits which didn't change behavior, and I picked the wrong commit message. I shall fix that as well. > > Ben Widawsky (13): > drm/i915: Kill gtt_end > drm/i915: Mappable_end can't ever be > end > drm/i915: Remove gtt_mappable_total > drm/i915: Create a gtt structure > drm/i915: Remove use on gma_bus_addr on gen6+ > drm/i915: Remove use of gtt_mappable_entries > drm/i915: Stop using gtt_total_entries > drm/i915: Move stolen_size to the new struct > agp/intel: decouple more of the agp-i915 sharing > drm/i915: Needs dmar, not > drm/i915: Cut out the infamous ILK w/a from AGP layer > drm/i915: Remove scratch page from shared > drm/i915: Finally kill off struct intel-gtt > > drivers/char/agp/intel-gtt.c | 88 ++++++--------- > drivers/gpu/drm/i915/i915_debugfs.c | 3 +- > drivers/gpu/drm/i915/i915_dma.c | 29 +++-- > drivers/gpu/drm/i915/i915_drv.h | 39 +++++-- > drivers/gpu/drm/i915/i915_gem.c | 18 ++-- > drivers/gpu/drm/i915/i915_gem_evict.c | 2 +- > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- > drivers/gpu/drm/i915/i915_gem_gtt.c | 167 > ++++++++++++++--------------- > drivers/gpu/drm/i915/i915_gem_stolen.c | 8 +- > drivers/gpu/drm/i915/i915_gem_tiling.c | 2 +- > drivers/gpu/drm/i915/i915_irq.c | 4 +- > drivers/gpu/drm/i915/intel_display.c | 2 +- > drivers/gpu/drm/i915/intel_fb.c | 5 +- > drivers/gpu/drm/i915/intel_overlay.c | 4 +- > drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- > include/drm/intel-gtt.h | 19 ---- 16 files > changed, 184 insertions(+), 210 deletions(-) >