From: Theodore Ts'o <tytso@mit.edu>
To: Darren Hart <dvhart@infradead.org>
Cc: linux-ext4@vger.kernel.org, adilger@dilger.ca,
sgw@linux.intel.com, darrick.wong@oracle.com
Subject: Re: [PATCH 1/3] lib/ext2fs: Add ext2fs_symlink
Date: Tue, 15 Jan 2013 14:17:14 -0500 [thread overview]
Message-ID: <20130115191714.GE17719@thunk.org> (raw)
In-Reply-To: <3fd850c4bf72f868b0d93bb0a5acced51fd25caa.1357329054.git.dvhart@infradead.org>
On Fri, Jan 04, 2013 at 12:00:58PM -0800, Darren Hart wrote:
Applied, thanks.
> Note the one remaining FIXME. Do I need to use ext2fs_bmap2() for the
> slowlink without extents? If not, how is the 0 block associated with the
> inode?
No, you don't need to use ext2fs_bmap2(). The 0 block was set here in
the else clause:
+ if (fs->super->s_feature_incompat &
+ EXT3_FEATURE_INCOMPAT_EXTENTS) {
+ /*
+ * The extent bmap is setup after the inode and block
+ * have been written out below.
+ */
+ inode.i_flags |= EXT4_EXTENTS_FL;
+ } else {
+ inode.i_block[0] = blk;
+ }
- Ted
next prev parent reply other threads:[~2013-01-15 19:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 20:00 [PATCH 0/3 V2] ext2fsprogs: Symlink support Darren Hart
2013-01-04 20:00 ` [PATCH 1/3] lib/ext2fs: Add ext2fs_symlink Darren Hart
2013-01-04 20:00 ` [PATCH 2/3] debugfs: Add symlink command Darren Hart
2013-01-04 20:01 ` [PATCH 3/3] libext2fs: Remove obsolete redefinition of EXT2_FT_DIR Darren Hart
2013-01-05 20:07 ` [PATCH 1/3] lib/ext2fs: Add ext2fs_symlink Darrick J. Wong
2013-01-05 22:40 ` Theodore Ts'o
2013-01-15 19:17 ` Theodore Ts'o [this message]
2013-01-15 19:43 ` Theodore Ts'o
2013-01-15 19:53 ` [PATCH 1/2] debugfs: fix mknod command so that it updates the block group statistics Theodore Ts'o
2013-01-15 19:53 ` [PATCH 2/2] tests: create test for debugfs creating special files Theodore Ts'o
2013-01-19 5:29 ` [PATCH 1/3] lib/ext2fs: Add ext2fs_symlink Darren Hart
2013-01-05 0:15 ` [PATCH 0/3 V2] ext2fsprogs: Symlink support Theodore Ts'o
2013-01-05 0:26 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115191714.GE17719@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=dvhart@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.