From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>, Liam Girdwood <lgirdwood@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH] ASoC: wm8978: SND_SOC_DAIFMT_NB_NF become default clock inversion
Date: Wed, 16 Jan 2013 01:04:17 +0000 [thread overview]
Message-ID: <20130116010417.GA15503@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <877gne6kvh.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Jan 15, 2013 at 04:18:30PM -0800, Kuninori Morimoto wrote:
> Current wm8978 driver return -EINVAL if it doesn't have
> SND_SOC_DAIFMT_INV_MASK flags on snd_soc_dai_ops :: set_fmt.
> But default settings should be treated as
> SND_SOC_DAIFMT_NB_NF (= no clock inversion).
I'd say the fix here is really to change the values of the flags so that
_NB_NF is zero - this is a widespread thing in drivers and it makes
sense from a user point of view too.
next prev parent reply other threads:[~2013-01-16 1:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 0:18 [PATCH] ASoC: wm8978: SND_SOC_DAIFMT_NB_NF become default clock inversion Kuninori Morimoto
2013-01-16 1:04 ` Mark Brown [this message]
2013-01-16 4:18 ` [PATCH] ASoC: SND_SOC_DAIFMT_NB_NF become 0 as default settings Kuninori Morimoto
2013-01-16 11:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116010417.GA15503@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.