All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Cc: git@vger.kernel.org, Per Cederqvist <cederp@opera.com>,
	Theodore Ts'o <tytso@mit.edu>, Iulian Udrea <iulian@linux.com>,
	Axel Beckert <abe@deuxchevaux.org>
Subject: [GUILT] [PATCH 5/7] Fix fatal "guilt graph" error in sha1sum invocation.
Date: Tue, 15 Jan 2013 18:29:13 -0800	[thread overview]
Message-ID: <20130116022913.GN12524@google.com> (raw)
In-Reply-To: <20130116022606.GI12524@google.com>

From: Per Cederqvist <cederp@opera.com>
Date: Wed, 14 Mar 2012 14:34:38 +0100

Fix the compatibility function sha1 so that it reads from
stdin (and not a file with a zero-length file name) when
no argument is supplied.

[jn: adapted to also handle newer versions of OpenSSL,
 based on reports from Andreas Schwab and John Szakmeister.

 $ openssl dgst -sha1</dev/null
 da39a3ee5e6b4b0d3255bfef95601890afd80709
 $ openssl version
 OpenSSL 0.9.8o 01 Jun 2010

 $ openssl dgst -sha1 </dev/null
 (stdin)= da39a3ee5e6b4b0d3255bfef95601890afd80709
 $ openssl version
 OpenSSL 1.0.0d 8 Feb 2011
]

Signed-off-by: Per Cederqvist <cederp@opera.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 os.Darwin | 7 ++++++-
 os.Linux  | 7 ++++++-
 os.SunOS  | 7 ++++++-
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/os.Darwin b/os.Darwin
index 470f5fb..3f23121 100644
--- a/os.Darwin
+++ b/os.Darwin
@@ -27,7 +27,12 @@ head_n()
 # usage: sha1 [file]
 sha1()
 {
-	openssl dgst -sha1 "$1" | sed "s,SHA1.\(.*\).= \(.*\),\2  \1,"
+	if [ $# = 1 ]
+	then
+		openssl dgst -sha1 "$1" | sed "s,SHA1.\(.*\).= \(.*\),\2  \1,"
+	else
+		openssl dgst -sha1 | sed 's,\(.*= \)*\(.*\),\2  -,'
+	fi
 }
 
 # usage: cp_a <src> <dst>
diff --git a/os.Linux b/os.Linux
index 30b9cb0..aaebf88 100644
--- a/os.Linux
+++ b/os.Linux
@@ -30,7 +30,12 @@ head_n()
 # usage: sha1 [file]
 sha1()
 {
-	sha1sum "$1"
+	if [ $# = 1 ]
+	then
+		sha1sum "$1"
+	else
+		sha1sum
+	fi
 }
 
 # usage: cp_a <src> <dst>
diff --git a/os.SunOS b/os.SunOS
index 30b9cb0..aaebf88 100644
--- a/os.SunOS
+++ b/os.SunOS
@@ -30,7 +30,12 @@ head_n()
 # usage: sha1 [file]
 sha1()
 {
-	sha1sum "$1"
+	if [ $# = 1 ]
+	then
+		sha1sum "$1"
+	else
+		sha1sum
+	fi
 }
 
 # usage: cp_a <src> <dst>
-- 
1.8.1

  parent reply	other threads:[~2013-01-16  2:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16  2:26 [PATCH 0/7] guilt patches, including git 1.8 support Jonathan Nieder
2013-01-16  2:27 ` [GUILT] [PATCH 1/7] get rid of "cat: write error: Broken pipe" error message Jonathan Nieder
2013-01-16  2:27 ` [GUILT] [PATCH 2/7] The tests should not fail if log.date or log.decorate are set Jonathan Nieder
2013-01-16  2:28 ` [GUILT] [PATCH 3/7] Testsuite: get rid of "Broken pipe" errors from yes Jonathan Nieder
2013-01-16  2:28 ` [GUILT] [PATCH 4/7] Handle empty patches and patches with only a header Jonathan Nieder
2013-01-16  2:29 ` Jonathan Nieder [this message]
2013-01-16  2:30 ` [GUILT] [PATCH 6/7] Change git branch when patches are applied Jonathan Nieder
2013-01-16  2:31 ` [GUILT] [PATCH 7/7] Drop unneeded git version check Jonathan Nieder
2013-01-16  3:26 ` [PATCH 0/7] guilt patches, including git 1.8 support Theodore Ts'o
2013-01-16 15:04   ` Josef 'Jeff' Sipek
2013-01-20 21:19 ` Per Cederqvist
2013-01-20 21:24   ` Josef 'Jeff' Sipek
2013-01-27 14:38 ` Josef 'Jeff' Sipek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130116022913.GN12524@google.com \
    --to=jrnieder@gmail.com \
    --cc=abe@deuxchevaux.org \
    --cc=cederp@opera.com \
    --cc=git@vger.kernel.org \
    --cc=iulian@linux.com \
    --cc=jeffpc@josefsipek.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.