Re: [PATCH v2 1/2] drm: constify edid handling functions

[Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

On Wed, Jan 16, 2013 at 03:36:41PM +0100, Lucas Stach wrote:
[...]
> @@ -705,7 +705,7 @@ static int standard_timing_level(struct edid *edid)
>   * monitors fill with ascii space (0x20) instead.
>   */
>  static int
> -bad_std_timing(u8 a, u8 b)
> +bad_std_timing(const u8 a, const u8 b)
>  {
>  	return (a == 0x00 && b == 0x00) ||
>  	       (a == 0x01 && b == 0x01) ||

Was this intended to go in here?

> @@ -721,8 +721,8 @@ bad_std_timing(u8 a, u8 b)
>   * and convert them into a real mode using CVT/GTF/DMT.
>   */
>  static struct drm_display_mode *
> -drm_mode_std(struct drm_connector *connector, struct edid *edid,
> -	     struct std_timing *t, int revision)
> +drm_mode_std(struct drm_connector *connector, const struct edid *edid,
> +	     const struct std_timing *t, int revision)
>  {
>  	struct drm_device *dev = connector->dev;
>  	struct drm_display_mode *m, *mode = NULL;

I know I'm being picky, but you're constifying the t parameter here as
well without saying so in the commit message.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]