All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Ding <dinggnu@gmail.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Pekka Enberg <penberg@kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Asias He <asias.hejun@gmail.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] kvm tools: remove redundant "if" condition
Date: Wed, 16 Jan 2013 17:52:40 +0100	[thread overview]
Message-ID: <20130116165239.GB18593@gmail.com> (raw)
In-Reply-To: <20130116113522.GR11529@redhat.com>

After we check (state.kcount != 0), state.kcount has to be 0 in all the "else"
branchs.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 tools/kvm/hw/i8042.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/kvm/hw/i8042.c b/tools/kvm/hw/i8042.c
index 9f8be6a..9035732 100644
--- a/tools/kvm/hw/i8042.c
+++ b/tools/kvm/hw/i8042.c
@@ -189,7 +189,7 @@ static u32 kbd_read_data(void)
 		state.mcount--;
 		kvm__irq_line(state.kvm, AUX_IRQ, 0);
 		kbd_update_irq();
-	} else if (state.kcount == 0) {
+	} else {
 		i = state.kread - 1;
 		if (i < 0)
 			i = QUEUE_SIZE;
-- 
1.7.10.4

  parent reply	other threads:[~2013-01-16 16:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16  1:07 [PATCH] kvm: close opened file Cong Ding
2013-01-16  1:07 ` [PATCH] kvm: remove redundant "if" condition Cong Ding
2013-01-16 11:35 ` [PATCH] kvm: close opened file Gleb Natapov
2013-01-16 16:51   ` [PATCH v2] kvm tools: " Cong Ding
2013-01-19  8:57     ` Pekka Enberg
2013-01-16 16:52   ` Cong Ding [this message]
2013-01-19  8:58     ` [PATCH v2] kvm tools: remove redundant "if" condition Pekka Enberg
2013-01-19 10:27       ` Cong Ding
2013-01-22 19:52         ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130116165239.GB18593@gmail.com \
    --to=dinggnu@gmail.com \
    --cc=asias.hejun@gmail.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.