From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH v3] test-lib.sh: unfilter GIT_PERF_*
Date: Wed, 16 Jan 2013 10:54:16 -0800 [thread overview]
Message-ID: <20130116185416.GA28866@google.com> (raw)
In-Reply-To: <1358331833-8289-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy wrote:
> These variables are user parameters to control how to run the perf
> tests. Allow users to do so.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
FWIW, of the three versions proposed, this one makes the most sense to
me. Looks good.
prev parent reply other threads:[~2013-01-16 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 12:53 [PATCH] test-lib.sh: unfilter GIT_PERF_* Nguyễn Thái Ngọc Duy
2013-01-15 13:43 ` Thomas Rast
2013-01-15 13:47 ` Duy Nguyen
2013-01-15 13:50 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-01-15 19:31 ` Junio C Hamano
2013-01-16 10:23 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2013-01-16 18:54 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116185416.GA28866@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.