From: Fengguang Wu <fengguang.wu@intel.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Subject: [tty:tty-next 42/62] drivers/tty/serial/sccnxp.c:894 sccnxp_probe() error: we previously assumed 'pdata' could be null (see line 887)
Date: Thu, 17 Jan 2013 09:22:42 +0800 [thread overview]
Message-ID: <20130117012242.GC7017@localhost> (raw)
In-Reply-To: <50f6ed06.V0pPrMkDV2E8vACU%fengguang.wu@intel.com>
Hi Alexander,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next
head: e27a7d7977b07d701ba247e2ddb95466d95c898f
commit: ec063899b7b308019afa9f5eb32f0a58a6c6ee53 [42/62] serial: sccnxp: Implement polling mode
New smatch warnings:
drivers/tty/serial/sccnxp.c:894 sccnxp_probe() error: we previously assumed 'pdata' could be null (see line 887)
vim +/pdata +894 drivers/tty/serial/sccnxp.c
1d65c0b1 Alexander Shiyan 2012-08-25 881 default:
1d65c0b1 Alexander Shiyan 2012-08-25 882 dev_err(&pdev->dev, "Unsupported chip type %i\n", chiptype);
1d65c0b1 Alexander Shiyan 2012-08-25 883 ret = -ENOTSUPP;
1d65c0b1 Alexander Shiyan 2012-08-25 884 goto err_out;
1d65c0b1 Alexander Shiyan 2012-08-25 885 }
1d65c0b1 Alexander Shiyan 2012-08-25 886
1d65c0b1 Alexander Shiyan 2012-08-25 @887 if (!pdata) {
1d65c0b1 Alexander Shiyan 2012-08-25 888 dev_warn(&pdev->dev,
1d65c0b1 Alexander Shiyan 2012-08-25 889 "No platform data supplied, using defaults\n");
1d65c0b1 Alexander Shiyan 2012-08-25 890 s->pdata.frequency = s->freq_std;
1d65c0b1 Alexander Shiyan 2012-08-25 891 } else
1d65c0b1 Alexander Shiyan 2012-08-25 892 memcpy(&s->pdata, pdata, sizeof(struct sccnxp_pdata));
1d65c0b1 Alexander Shiyan 2012-08-25 893
ec063899 Alexander Shiyan 2012-12-03 @894 if (pdata->poll_time_us) {
ec063899 Alexander Shiyan 2012-12-03 895 dev_info(&pdev->dev, "Using poll mode, resolution %u usecs\n",
ec063899 Alexander Shiyan 2012-12-03 896 pdata->poll_time_us);
ec063899 Alexander Shiyan 2012-12-03 897 s->poll = 1;
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
next parent reply other threads:[~2013-01-17 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50f6ed06.V0pPrMkDV2E8vACU%fengguang.wu@intel.com>
2013-01-17 1:22 ` Fengguang Wu [this message]
2013-01-17 6:59 [tty:tty-next 42/62] drivers/tty/serial/sccnxp.c:894 sccnxp_probe() error: we previously assumed 'pdata' could be null (see line 887) Dan Carpenter
2013-01-17 7:11 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117012242.GC7017@localhost \
--to=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.