All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alex Williamson <alex.williamson@redhat.com>, kbuild@01.org
Cc: kvm@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>
Subject: [vfio:vfio-vga 3/5] drivers/vfio/pci/vfio_pci_rdwr.c:169 vfio_pci_bar_rw() warn: always true condition '(done >= 0) => (0-u32max >= 0)'
Date: Thu, 17 Jan 2013 10:03:06 +0300	[thread overview]
Message-ID: <20130117070306.GG16282@mwanda> (raw)

Hi Alex,

FYI, there are new smatch warnings show up in

tree:   git://github.com/awilliam/linux-vfio.git vfio-vga
head:   2c2e21fa66c40ed7b8e434c86a9f2ab0c879f21d
commit: f4d38f216ef420595d12f74b256b3961eb4c3c14 [3/5] vfio-pci: Cleanup BAR access

New smatch warnings:
drivers/vfio/pci/vfio_pci_rdwr.c:169 vfio_pci_bar_rw() warn: always true condition '(done >= 0) => (0-u32max >= 0)'

git remote add vfio git://github.com/awilliam/linux-vfio.git
git remote update vfio
git checkout f4d38f216ef420595d12f74b256b3961eb4c3c14
vim +169 drivers/vfio/pci/vfio_pci_rdwr.c

f4d38f21 Alex Williamson 2013-01-16  153  		if (!io) {
f4d38f21 Alex Williamson 2013-01-16  154  			pci_release_selected_regions(pdev, 1 << bar);
f4d38f21 Alex Williamson 2013-01-16  155  			return -ENOMEM;
89e1f7d4 Alex Williamson 2012-07-31  156  		}
89e1f7d4 Alex Williamson 2012-07-31  157  
f4d38f21 Alex Williamson 2013-01-16  158  		vdev->barmap[bar] = io;
f4d38f21 Alex Williamson 2013-01-16  159  	} else
89e1f7d4 Alex Williamson 2012-07-31  160  		io = vdev->barmap[bar];
89e1f7d4 Alex Williamson 2012-07-31  161  
f4d38f21 Alex Williamson 2013-01-16  162  	if (bar == vdev->msix_bar) {
f4d38f21 Alex Williamson 2013-01-16  163  		x_start = vdev->msix_offset;
f4d38f21 Alex Williamson 2013-01-16  164  		x_end = vdev->msix_offset + vdev->msix_size;
89e1f7d4 Alex Williamson 2012-07-31  165  	}
89e1f7d4 Alex Williamson 2012-07-31  166  
f4d38f21 Alex Williamson 2013-01-16  167  	done = do_io_rw(io, buf, pos, count, x_start, x_end, iswrite);
89e1f7d4 Alex Williamson 2012-07-31  168  
f4d38f21 Alex Williamson 2013-01-16 @169  	if (done >= 0)
f4d38f21 Alex Williamson 2013-01-16  170  		*ppos += done;
89e1f7d4 Alex Williamson 2012-07-31  171  
89e1f7d4 Alex Williamson 2012-07-31  172  	if (bar == PCI_ROM_RESOURCE)
89e1f7d4 Alex Williamson 2012-07-31  173  		pci_unmap_rom(pdev, io);
89e1f7d4 Alex Williamson 2012-07-31  174  
f4d38f21 Alex Williamson 2013-01-16  175  	return done;
89e1f7d4 Alex Williamson 2012-07-31  176  }

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

                 reply	other threads:[~2013-01-17  7:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130117070306.GG16282@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=alex.williamson@redhat.com \
    --cc=kbuild@01.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.