From: Timo Teras <timo.teras@iki.fi>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: David Miller <davem@davemloft.net>, Julian Anastasov <ja@ssi.bg>,
luky-37@hotmail.com, pupilla@libero.it, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ipv4: Remove output route check in ipv4_mtu
Date: Thu, 17 Jan 2013 10:35:15 +0200 [thread overview]
Message-ID: <20130117103515.338f5b1a@vostro> (raw)
In-Reply-To: <20130117065500.GG18940@secunet.com>
On Thu, 17 Jan 2013 07:55:01 +0100 Steffen Klassert
<steffen.klassert@secunet.com> wrote:
> The output route check was introduced with git commit 261663b0
> (ipv4: Don't use the cached pmtu informations for input routes)
> during times when we cached the pmtu informations on the
> inetpeer. Now the pmtu informations are back in the routes,
> so this check is obsolete. It also had some unwanted side effects,
> as reported by Timo Teras and Lukas Tribus.
>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
> ---
Acked-by: Timo Teräs <timo.teras@iki.fi>
I think this should also go to stable queues which are applicable, since
the original commit caused CLAMPMSS and XFRM pmtu regressions.
The original thread of this is:
http://marc.info/?t=134208398500001&r=1&w=2
My original revert request is at:
http://marc.info/?l=linux-netdev&m=134242561624266&w=2
and additional reasoning at:
http://marc.info/?l=linux-netdev&m=134243626627716&w=2
Thanks,
Timo
next prev parent reply other threads:[~2013-01-17 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 6:55 [PATCH 1/2] ipv4: Remove output route check in ipv4_mtu Steffen Klassert
2013-01-17 6:58 ` [PATCH 2/2] ipv4: Don't update the pmtu on mtu locked routes Steffen Klassert
2013-01-17 8:40 ` David Miller
2013-01-17 8:41 ` Julian Anastasov
2013-01-17 8:35 ` Timo Teras [this message]
2013-01-17 8:40 ` [PATCH 1/2] ipv4: Remove output route check in ipv4_mtu David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117103515.338f5b1a@vostro \
--to=timo.teras@iki.fi \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=luky-37@hotmail.com \
--cc=netdev@vger.kernel.org \
--cc=pupilla@libero.it \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.