From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: "Hill, Steven" <sjhill@mips.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"cernekee@gmail.com" <cernekee@gmail.com>,
"kevink@paralogos.com" <kevink@paralogos.com>
Subject: Re: [PATCH] [RFC] Proposed changes to eliminate 'union mips_instruction' type.
Date: Thu, 17 Jan 2013 15:05:10 +0100 [thread overview]
Message-ID: <20130117140510.GA19406@linux-mips.org> (raw)
In-Reply-To: <50F7289A.3000102@gmail.com>
On Wed, Jan 16, 2013 at 02:24:26PM -0800, David Daney wrote:
> ... In the very last BITFIELD_FIELD(), you need a valid token as the
> second parameter, otherwise (according to Pinski) C90 behavior is
> undefined.
>
> Use a ';'
While Andrew is correct, I don't think this argument matters unless
we're going to export <asm/inst.h> to userspace. Should we? Historically
it was meant to be exported and accessed by application code from
<sys/inst.h>.
Ralf
next prev parent reply other threads:[~2013-01-17 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 6:13 [PATCH] [RFC] Proposed changes to eliminate 'union mips_instruction' type Steven J. Hill
2013-01-15 8:24 ` Ralf Baechle
2013-01-15 19:41 ` David Daney
2013-01-15 22:19 ` Hill, Steven
2013-01-15 22:39 ` David Daney
2013-01-16 14:16 ` Ralf Baechle
2013-01-16 22:24 ` David Daney
2013-01-17 14:05 ` Ralf Baechle [this message]
2013-01-16 18:57 ` David Daney
2013-01-16 21:50 ` Hill, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117140510.GA19406@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=cernekee@gmail.com \
--cc=ddaney.cavm@gmail.com \
--cc=kevink@paralogos.com \
--cc=linux-mips@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.