From: Dave Jones <davej@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Josh Boyer <jwboyer@redhat.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
dhowells@redhat.com, linux-kernel@vger.kernel.org,
peterz@infradead.org, mingo@redhat.com
Subject: Re: [PATCH] MODSIGN: Add TAINT_NOKEY_MODULE
Date: Thu, 17 Jan 2013 10:02:02 -0500 [thread overview]
Message-ID: <20130117150202.GB32586@redhat.com> (raw)
In-Reply-To: <87pq14y6bs.fsf@rustcorp.com.au>
On Thu, Jan 17, 2013 at 11:27:27AM +1030, Rusty Russell wrote:
> taint: add explicit flag to show whether lock dep is still OK.
>
> Fix up all callers as they were before, with make one change: an
> unsigned module taints the kernel, but doesn't turn off lockdep.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This made my brain itch a little until I got to the bottom of the
patch and saw the new definition of add_taint. Perhaps instead of
false/true, we have LOCKDEP_LIVES/LOCKDEP_DIES or similar defines
to make it clearer what's actually happening without having to
go read the function ?
> + * If something bad has gone wrong, you'll want @lockdebug_ok = false, but for
> + * some notewortht-but-not-corrupting cases, it can be set to true.
> + */
'noteworthy'
Dave
next prev parent reply other threads:[~2013-01-17 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 19:12 [PATCH] MODSIGN: Don't taint unless signature enforcing is enabled Josh Boyer
2013-01-07 1:09 ` Rusty Russell
2013-01-07 14:58 ` Josh Boyer
2013-01-15 19:09 ` [PATCH] MODSIGN: Add TAINT_NOKEY_MODULE Josh Boyer
2013-01-16 3:34 ` Rusty Russell
2013-01-16 13:21 ` Josh Boyer
2013-01-16 19:37 ` Josh Boyer
2013-01-17 0:57 ` Rusty Russell
2013-01-17 15:02 ` Dave Jones [this message]
[not found] ` <8738xvxv55.fsf@rustcorp.com.au>
2013-01-21 0:19 ` Frank Ch. Eigler
2013-01-21 1:50 ` Rusty Russell
2013-01-21 0:46 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117150202.GB32586@redhat.com \
--to=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=fche@redhat.com \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.