All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arvin Schnell <aschnell@suse.de>
To: chris.mason@fusionio.com, linux-btrfs@vger.kernel.org
Subject: [PATCH] trivial patch for btrfs-progs
Date: Thu, 17 Jan 2013 16:09:32 +0100	[thread overview]
Message-ID: <20130117150932.GA11610@suse.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]


Hi,

please find attached a trivial patch for btrfs-progs. Likely not
strictly needed but I noticed valgrind complaining about
uninitialised memory in the ioctl call.

Regards,
  Arvin

-- 
Arvin Schnell, <aschnell@suse.de>
Senior Software Engineer, Research & Development
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstraße 5
90409 Nürnberg
Germany

[-- Attachment #2: memset.diff --]
[-- Type: text/x-patch, Size: 320 bytes --]

diff --git a/cmds-send.c b/cmds-send.c
index 9b47e70..aa8c5a3 100644
--- a/cmds-send.c
+++ b/cmds-send.c
@@ -271,6 +271,7 @@ static int do_send(struct btrfs_send *send, u64 root_id, u64 parent_root)
 		goto out;
 	}
 
+	memset(&io_send, 0, sizeof(io_send));
 	io_send.send_fd = pipefd[1];
 	send->send_fd = pipefd[0];
 

                 reply	other threads:[~2013-01-17 15:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130117150932.GA11610@suse.de \
    --to=aschnell@suse.de \
    --cc=chris.mason@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.