From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Thu, 17 Jan 2013 17:14:33 +0100 Subject: [PATCH] [RFC] ARM: compile fix for DEBUG_LL=y && MMU=n In-Reply-To: <20130116223144.GA9071@quad.lixom.net> References: <1358346726-27199-1-git-send-email-u.kleine-koenig@pengutronix.de> <20130116223144.GA9071@quad.lixom.net> Message-ID: <20130117161433.GL8668@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 16, 2013 at 02:31:44PM -0800, Olof Johansson wrote: > On Wed, Jan 16, 2013 at 03:32:06PM +0100, Uwe Kleine-K?nig wrote: > > debug_ll_addr is only used on machines with an MMU so it can be #ifdef'ed > > out safely. This fixes: > > > > arch/arm/kernel/debug.S: Assembler messages: > > arch/arm/kernel/debug.S:104: Error: too many positional arguments > > > > Signed-off-by: Uwe Kleine-K?nig > > Cc: Rob Herring > > Cc: Stephen Warren > > Cc: Olof Johansson > > --- > > The obvious alternative fix is to make addruart on !MMU take 3 > > arguments, too. > > > > The problem was introduced in > > > > e5c5f2a (ARM: implement debug_ll_io_init()) > > > > which appeared in v3.8-rc1. > > Since we introduced the breakage in arm-soc, I've picked up the fix (I guess > it could have gone through Russell's tree as well though). > > I've added the reference to the introducing commit, and the acks/review tags. > > Adding a defconfig for a !MMU platform seems like a good idea, since there's > several of us who make sure that there is build coverage of the defconfigs and > follow up on most of the breakage. Feel free to send one in for 3.9. Jonny just pointed out in irc that there is at91x40_defconfig. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |