From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757304Ab3AQQcH (ORCPT ); Thu, 17 Jan 2013 11:32:07 -0500 Received: from mail.kernel.org ([198.145.19.201]:34689 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757181Ab3AQQcB (ORCPT ); Thu, 17 Jan 2013 11:32:01 -0500 Date: Thu, 17 Jan 2013 08:31:59 -0800 From: Greg Kroah-Hartman To: Pantelis Antoniou Cc: linux-kernel@vger.kernel.org, Matt Porter , Russ Dill , Koen Kooi Subject: Re: [PATCH] platform: Fix platform device resource linking Message-ID: <20130117163159.GD1396@kroah.com> References: <1357252270-5955-1-git-send-email-panto@antoniou-consulting.com> <20130103224020.GB4571@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 04, 2013 at 12:43:46AM +0200, Pantelis Antoniou wrote: > Hi Greg, > > On Jan 4, 2013, at 12:40 AM, Greg Kroah-Hartman wrote: > > > On Fri, Jan 04, 2013 at 12:31:10AM +0200, Pantelis Antoniou wrote: > >> Platform device removal uncovered a number of problems with > >> the way resources are handled in the core platform code. > >> > >> Resources now form child/parent linkages and this requires > >> proper linking of the resources. On top of that the OF core > >> directly creates it's own platform devices. Simplify things > >> by providing helper functions that manage the linking properly. > >> > >> Two functions are provided: > >> > >> platform_device_link_resources(), which links all the > >> linkable resources (if not already linked). > >> > >> and platform_device_unlink_resources(), which unlinks all the > >> resources. > > > > Who would call these functions, and why? > > > > And why have we never seen problems with removing platform devices > > previously? > > > > Have you tried removing devices that were created via DT and > not using platform data? Don't you think that answering two questions with another question as something that isn't very helpful? :) Dropped from my queue, please resend when you can provide the needed information. thanks, greg k-h