From: Gleb Natapov <gleb@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>,
mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 0/4] KVM: Clean up and optimize __kvm_set_memory_region() - part1
Date: Thu, 17 Jan 2013 18:35:40 +0200 [thread overview]
Message-ID: <20130117163540.GA10107@redhat.com> (raw)
In-Reply-To: <20130117232653.c7b8c5c723441e01453f14aa@gmail.com>
On Thu, Jan 17, 2013 at 11:26:53PM +0900, Takuya Yoshikawa wrote:
> On Thu, 17 Jan 2013 14:42:02 +0200
> Gleb Natapov <gleb@redhat.com> wrote:
>
> > Applied 1-3. It is not clear whether kvm_iommu_map_pages() should be called
> > when flags change, so not applying 4 for now.
>
> Thank you.
>
> Although I confirmed that kvm_iommu_map_pages() does nothing with
> the flags, it needs to be confirmed by the author.
>
Yes, it may be a bug. I asked Alex in other email.
> Another thing I'm not 100% sure about the API is whether we can
> change the flags when we move the base: flags + move. The current
> implementation allows it, but not sure if it's a good thing.
>
> Takuya
--
Gleb.
prev parent reply other threads:[~2013-01-17 16:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 9:25 [PATCH 0/4] KVM: Clean up and optimize __kvm_set_memory_region() - part1 Takuya Yoshikawa
2013-01-11 9:26 ` [PATCH 1/4] KVM: set_memory_region: Don't jump to out_free unnecessarily Takuya Yoshikawa
2013-01-11 9:26 ` [PATCH 2/4] KVM: set_memory_region: Don't check for overlaps unless we create or move a slot Takuya Yoshikawa
2013-01-11 9:27 ` [PATCH 3/4] KVM: set_memory_region: Remove unnecessary variable memslot Takuya Yoshikawa
2013-01-11 9:28 ` [PATCH 4/4] KVM: set_memory_region: Identify the requested change explicitly Takuya Yoshikawa
2013-01-16 19:07 ` [PATCH 0/4] KVM: Clean up and optimize __kvm_set_memory_region() - part1 Marcelo Tosatti
2013-01-17 3:20 ` Xiao Guangrong
2013-01-17 7:29 ` Gleb Natapov
2013-01-17 17:12 ` Alex Williamson
2013-01-17 17:20 ` Gleb Natapov
2013-01-17 17:30 ` Alex Williamson
2013-01-17 17:58 ` Gleb Natapov
2013-01-17 18:25 ` Alex Williamson
2013-01-17 12:40 ` Marcelo Tosatti
2013-01-17 12:42 ` Gleb Natapov
2013-01-17 14:26 ` Takuya Yoshikawa
2013-01-17 16:35 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117163540.GA10107@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa_takuya_b1@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.