From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 3/3] netfilter: ctnetlink: allow userspace to modify labels
Date: Fri, 18 Jan 2013 00:39:35 +0100 [thread overview]
Message-ID: <20130117233935.GC15996@1984> (raw)
In-Reply-To: <1357921846-29650-4-git-send-email-fw@strlen.de>
On Fri, Jan 11, 2013 at 05:30:46PM +0100, Florian Westphal wrote:
> Add the ability to set/clear labels assigned to a conntrack
> via ctnetlink.
>
> To allow userspace to only alter specific bits, Pablo suggested to add
> a new CTA_LABELS_MASK attribute:
>
> The new set of active labels is then determined via
>
> active = (active & ~mask) ^ changeset
>
> i.e., the mask selects those bits in the existing set that should be
> changed.
>
> This follows the same method already used by MARK and CONNMARK targets.
>
> Omitting CTA_LABELS_MASK is the same as setting all bits in CTA_LABELS_MASK
> to 1: The existing set is replaced by the one from userspace.
And this also applied, thanks Florian.
You can push the user-space changes for this into some new -next
branch of each tree. Then merge it to master by when 3.9-rc1 is
released.
prev parent reply other threads:[~2013-01-17 23:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 16:30 [PATCH next V2] netfilter connlabel extension Florian Westphal
2013-01-11 16:30 ` [PATCH 1/3] netfilter: add connlabel conntrack extension Florian Westphal
2013-01-17 23:37 ` Pablo Neira Ayuso
2013-01-11 16:30 ` [PATCH 2/3] netfilter: ctnetlink: deliver labels to userspace Florian Westphal
2013-01-17 23:38 ` Pablo Neira Ayuso
2013-01-11 16:30 ` [PATCH 3/3] netfilter: ctnetlink: allow userspace to modify labels Florian Westphal
2013-01-17 23:39 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117233935.GC15996@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.