From: Anatolij Gustschin <agust@denx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/video: fsl-diu-fb: fix bugs in interrupt handling
Date: Thu, 17 Jan 2013 23:11:07 +0000 [thread overview]
Message-ID: <20130118001107.2a2c20ea@crub> (raw)
In-Reply-To: <1358454518-14032-2-git-send-email-agust@denx.de>
On Thu, 17 Jan 2013 16:20:04 -0600
Timur Tabi <timur@tabi.org> wrote:
...
> This is why you need hacks like can_handle_irq. So I'm not crazy about
> this patch. I think you need to get rid of can_handle_irq and allow the
> interrupt handler to be registered before the hardware is initialized.
It makes sense. More testing shows that disabling interrupts in
fsl_diu_release() needs to be fixed, too. If the fb0 plane is opened
(i.e. by fbcon) and another app opens an overlay plane i.e. on /dev/fb1
and then closes it, the diu interrupts will be disabled, even though the
first plane is still opened.
Thanks,
Anatolij
prev parent reply other threads:[~2013-01-17 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 20:28 [PATCH 2/2] drivers/video: fsl-diu-fb: fix bugs in interrupt handling Anatolij Gustschin
2013-01-17 22:20 ` Timur Tabi
2013-01-17 23:11 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118001107.2a2c20ea@crub \
--to=agust@denx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.