From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Thu, 17 Jan 2013 17:25:50 -0800 Subject: [PATCH 3/4 v3] serial: vt8500: UART uses gated clock rather than 24Mhz reference In-Reply-To: <1358363143-7154-4-git-send-email-linux@prisktech.co.nz> References: <1358363143-7154-1-git-send-email-linux@prisktech.co.nz> <1358363143-7154-4-git-send-email-linux@prisktech.co.nz> Message-ID: <20130118012550.GA28958@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 17, 2013 at 08:05:42AM +1300, Tony Prisk wrote: > UART modules on Wondermedia SoCs are connected via a gated clock > source, rather than directly to the 24Mhz reference clock. While > uboot enables UART0 for debugging, other UART ports are unavailable > until the clock is enabled. > > This patch checks that a valid clock is actually passed from devicetree, > enables the clock in probe. This change removes the fallback when a > clock was not specified as it doesn't apply any longer (and would only > work if the UART clock was already enabled). > > DTSI files are updated for VT8500, WM8505 and WM8650. > > Signed-off-by: Tony Prisk > --- > arch/arm/boot/dts/vt8500.dtsi | 40 +++++++++++++++++++++--- > arch/arm/boot/dts/wm8505.dtsi | 60 ++++++++++++++++++++++++++++++++---- > arch/arm/boot/dts/wm8650.dtsi | 20 ++++++++++-- > drivers/tty/serial/vt8500_serial.c | 34 +++++++++++--------- > 4 files changed, 127 insertions(+), 27 deletions(-) PLEASE always use checkpatch.pl on your patches before sending them, so people don't have to write emails saying "why didn't you fix the checkpatch.pl errors in your patch" much like this one. Sorry, not applied. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754150Ab3ARBb4 (ORCPT ); Thu, 17 Jan 2013 20:31:56 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:63322 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808Ab3ARBbz (ORCPT ); Thu, 17 Jan 2013 20:31:55 -0500 Date: Thu, 17 Jan 2013 17:25:50 -0800 From: Greg KH To: Tony Prisk Cc: vt8500-wm8505-linux-kernel@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk Subject: Re: [PATCH 3/4 v3] serial: vt8500: UART uses gated clock rather than 24Mhz reference Message-ID: <20130118012550.GA28958@kroah.com> References: <1358363143-7154-1-git-send-email-linux@prisktech.co.nz> <1358363143-7154-4-git-send-email-linux@prisktech.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358363143-7154-4-git-send-email-linux@prisktech.co.nz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 17, 2013 at 08:05:42AM +1300, Tony Prisk wrote: > UART modules on Wondermedia SoCs are connected via a gated clock > source, rather than directly to the 24Mhz reference clock. While > uboot enables UART0 for debugging, other UART ports are unavailable > until the clock is enabled. > > This patch checks that a valid clock is actually passed from devicetree, > enables the clock in probe. This change removes the fallback when a > clock was not specified as it doesn't apply any longer (and would only > work if the UART clock was already enabled). > > DTSI files are updated for VT8500, WM8505 and WM8650. > > Signed-off-by: Tony Prisk > --- > arch/arm/boot/dts/vt8500.dtsi | 40 +++++++++++++++++++++--- > arch/arm/boot/dts/wm8505.dtsi | 60 ++++++++++++++++++++++++++++++++---- > arch/arm/boot/dts/wm8650.dtsi | 20 ++++++++++-- > drivers/tty/serial/vt8500_serial.c | 34 +++++++++++--------- > 4 files changed, 127 insertions(+), 27 deletions(-) PLEASE always use checkpatch.pl on your patches before sending them, so people don't have to write emails saying "why didn't you fix the checkpatch.pl errors in your patch" much like this one. Sorry, not applied. greg k-h