Re: [RFC PATCH 0/15]: PVH xen: Patches for PVH guests

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Tue, Jan 15, 2013 at 11:49:27AM -0800, Mukesh Rathor wrote:
> On Tue, 15 Jan 2013 17:38:33 +0100
> Roger Pau Monné <roger.pau@citrix.com> wrote:
> 
> > On 14/01/13 23:40, Mukesh Rathor wrote:
> 
> Hi Roger,
> 
> Ah yes, you need the following patch on your linux side. Please keep
> me posted how it goes, and whatever testing/performance stuff you do.

Jan had some comments about that patch:

https://patchwork.kernel.org/patch/1745041/

Please fix it up so I can put it in the Linux tree.

> 
> Don't forget CONFIG_XEN_X86_PVH btw :).
> 
> Thanks,
> Mukesh
> 
> 
> 
> >From 7a7b03ff160840edf43e7213d14e4a7620874a73 Mon Sep 17 00:00:00 2001
> From: Mukesh Rathor <mukesh.rathor@oracle.com>
> Date: Wed, 14 Nov 2012 18:16:54 -0800
> Subject: [PATCH 13/13] PVH: remove macro FEATURES_PVH and put PVH
> strings in the ELFNOTE line, because there's a null char before
> FEATURES_PVH and in the FEATURES_PVH strings since this is not C file
> 
> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
> ---
>  arch/x86/xen/xen-head.S |   14 +++++---------
>  1 files changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
> index 1a6bca1..340fd4e 100644
> --- a/arch/x86/xen/xen-head.S
> +++ b/arch/x86/xen/xen-head.S
> @@ -13,14 +13,6 @@
>  #include <xen/interface/elfnote.h>
>  #include <asm/xen/interface.h>
>  
> -#ifdef CONFIG_XEN_X86_PVH
> -#define FEATURES_PVH "|writable_descriptor_tables" \
> -		     "|auto_translated_physmap" \
> -		     "|supervisor_mode_kernel" \
> -		     "|hvm_callback_vector"
> -#else
> -#define FEATURES_PVH /* Not supported */
> -#endif
>  
>  	__INIT
>  ENTRY(startup_xen)
> @@ -104,7 +96,11 @@ NEXT_HYPERCALL(arch_6)
>  #endif
>  	ELFNOTE(Xen, XEN_ELFNOTE_ENTRY,          _ASM_PTR startup_xen)
>  	ELFNOTE(Xen, XEN_ELFNOTE_HYPERCALL_PAGE, _ASM_PTR
> hypercall_page)
> -	ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .asciz
> "!writable_page_tables|pae_pgdir_above_4gb"FEATURES_PVH) +#ifdef
> CONFIG_XEN_X86_PVH
> +        ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .asciz
> "!writable_page_tables|pae_pgdir_above_4gb|writable_descriptor_tables|auto_translated_physmap|supervisor_mode_kernel|hvm_callback_vector")
> +#else
> +        ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .asciz
> "!writable_page_tables|pae_pgdir_above_4gb")+#endif
>  	ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE,       .asciz "yes")
>  	ELFNOTE(Xen, XEN_ELFNOTE_LOADER,         .asciz "generic")
>  	ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID,
> -- 
> 1.7.2.3
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>