From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chris Rattray <crattray@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lrg@ti.com
Subject: Re: [PATCH 1/2] ASoC: wm_adsp: Set ADSP1 clock rate to match sys clock
Date: Fri, 18 Jan 2013 15:17:13 +0900 [thread overview]
Message-ID: <20130118061711.GB4960@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1358428307-30196-1-git-send-email-crattray@opensource.wolfsonmicro.com>
On Thu, Jan 17, 2013 at 01:11:46PM +0000, Chris Rattray wrote:
> #define ADSP1_CONTROL_30 0x24
> #define ADSP1_CONTROL_31 0x26
>
> +#define ADSP1_CLOCKING 38
> +/*
> + * ADSP1 Control 31
> + */
> +#define ADSP1_CLK_SEL_MASK 0x0007 /* CLK_SEL_ENA */
> +#define ADSP1_CLK_SEL_SHIFT 0 /* CLK_SEL_ENA */
> +#define ADSP1_CLK_SEL_WIDTH 3 /* CLK_SEL_ENA */
You just called this ADSP1_CLOCKING above, using a different style to
the other register #defines too (and of course there's already one for
the helpfully named ADSP1 Control 31...).
next prev parent reply other threads:[~2013-01-18 6:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 13:11 [PATCH 1/2] ASoC: wm_adsp: Set ADSP1 clock rate to match sys clock Chris Rattray
2013-01-17 13:11 ` [PATCH 2/2] ASoC: wm2200: Set system clock control register is adsp structs Chris Rattray
2013-01-18 6:17 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-01-18 8:43 [PATCH 1/2] ASoC: wm_adsp: Set ADSP1 clock rate to match sys clock Chris Rattray
2013-01-18 8:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118061711.GB4960@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=crattray@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.