From: Steffen Klassert <steffen.klassert@secunet.com>
To: "Yurij M. Plotnikov" <Yurij.Plotnikov@oktetlabs.ru>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
netdev@vger.kernel.org,
"Alexandra N. Kossovsky" <Alexandra.Kossovsky@oktetlabs.ru>
Subject: Re: PMTU discovery is broken on kernel 3.7.1 for UDP sockets
Date: Fri, 18 Jan 2013 09:11:45 +0100 [thread overview]
Message-ID: <20130118081145.GB24987@secunet.com> (raw)
In-Reply-To: <50F3C153.9030204@oktetlabs.ru>
On Mon, Jan 14, 2013 at 12:26:59PM +0400, Yurij M. Plotnikov wrote:
>
> Could you, please, tell me is there any news about this bug?
>
Ok, I tried to reconstruct your testcase and I can confirm this bug.
It happens only on the first pmtu event on a given route. It works
if I run this test again. Actually it works sometimes even on the
first pmtu event, so it took me quite a while to understand what's ging on.
This is because standart routes (no pmtu or redirect events happened on
that route) are per cpu, so each cpu has it's own struct rtable. This means
that we do not invalidate the socket cached route if the NET_RX_SOFTIRQ
(which handles the pmtu event) is not served by the same cpu that the
sending socket uses. Exceptional routes (routes where a pmtu or redirect
event occured) are not per cpu, so there is no problem.
I'll send three patches in reply to this mail. Applying patch one and two
should fix the bug you reported. If you use IPsec you need patch three too.
The patches are marked as RFC, I'll do proper patch submission if you can
confirm that they fix this bug.
next prev parent reply other threads:[~2013-01-18 8:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 13:10 PMTU discovery is broken on kernel 3.7.1 for UDP sockets Yurij M. Plotnikov
2012-12-19 13:35 ` Ben Hutchings
2012-12-19 14:27 ` Yurij M. Plotnikov
2012-12-19 19:37 ` Ben Hutchings
2012-12-20 7:14 ` Yurij M. Plotnikov
2012-12-20 7:34 ` Steffen Klassert
2012-12-20 11:22 ` Yurij M. Plotnikov
2012-12-20 12:35 ` Steffen Klassert
2012-12-21 10:22 ` Steffen Klassert
2013-01-14 8:26 ` Yurij M. Plotnikov
2013-01-14 12:52 ` Steffen Klassert
2013-01-18 8:11 ` Steffen Klassert [this message]
2013-01-18 8:14 ` [RFC PATCH 1/3] ipv4: Invalidate the socket cached route on pmtu events if possible Steffen Klassert
2013-01-18 19:38 ` David Miller
2013-01-19 0:54 ` Julian Anastasov
2013-01-21 6:43 ` Steffen Klassert
2013-01-18 8:15 ` [RFC PATCH 2/3] ipv4: Add a socket release callback for datagram sockets Steffen Klassert
2013-01-18 19:39 ` David Miller
2013-01-18 8:16 ` [RFC PATCH 3/3] xfrm4: Invalidate all ipv4 routes on IPsec pmtu events Steffen Klassert
2013-01-18 19:39 ` David Miller
2013-01-21 6:48 ` Steffen Klassert
2013-01-21 12:04 ` Steffen Klassert
2013-01-21 11:31 ` PMTU discovery is broken on kernel 3.7.1 for UDP sockets Yurij M. Plotnikov
2013-01-21 11:38 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118081145.GB24987@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=Alexandra.Kossovsky@oktetlabs.ru \
--cc=Yurij.Plotnikov@oktetlabs.ru \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.