All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: "André Przywara" <andre@andrep.de>,
	"Leonid Isaev" <lisaev@umail.iu.edu>,
	"Rafael J. Wysocki" <rjw@sisk.pl>, "Tom Gundersen" <teg@jklm.no>,
	"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [arch-general] powernow-k8 fails to load with linux 3.7.2
Date: Fri, 18 Jan 2013 16:26:33 +0100	[thread overview]
Message-ID: <20130118152633.GA4062@pd.tnic> (raw)
In-Reply-To: <E99CBA9F97C3D149AA6B19ED2E277C9B0193997E@BY2PRD0510MB365.namprd05.prod.outlook.com>

On Fri, Jan 18, 2013 at 03:17:04PM +0000, Matthew Garrett wrote:
> Can you try this (entirely untested) patch?
> 
> diff --git a/drivers/cpufreq/acpi-cpufreq.c
> b/drivers/cpufreq/acpi-cpufreq.c
> index 0d048f6..7b0d49d 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -1030,4 +1030,11 @@ MODULE_PARM_DESC(acpi_pstate_strict,
>  late_initcall(acpi_cpufreq_init);
>  module_exit(acpi_cpufreq_exit);
>  
> +static const struct x86_cpu_id acpi_cpufreq_ids[] = {
> +	X86_FEATURE_MATCH(X86_FEATURE_ACPI),
> +	X86_FEATURE_MATCH(X86_FEATURE_HW_PSTATE),
> +	{}

Yep, that should be one way to fix it.

One other fix IMHO would be if udev is looking at CPUID bits, to teach
it to check the proper P-States feature bits on Intel and AMD:

On Intel: CPUID_0x00000001[ECX] bit 7
On AMD  : CPUID_0x80000007[EDX] bit 7

AFAICT.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2013-01-18 15:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130115224755.085aa6b7@bluemoon>
     [not found] ` <CAG-2HqWPOYKVCj-Z=z_1e=mE6b6z9hMYFJzHf2GYAmTwQovN0A@mail.gmail.com>
     [not found]   ` <20130116131725.4e590c34@bluemoon>
2013-01-16 20:37     ` [arch-general] powernow-k8 fails to load with linux 3.7.2 Tom Gundersen
2013-01-16 22:33       ` Rafael J. Wysocki
2013-01-16 23:17         ` Borislav Petkov
     [not found]           ` <20130116181600.4c48ee3b@bluemoon>
2013-01-17  9:46             ` Borislav Petkov
2013-01-17 10:34               ` Tom Gundersen
2013-01-18  1:27                 ` Leonid Isaev
2013-01-18  1:40               ` Leonid Isaev
2013-01-18 11:37                 ` Borislav Petkov
2013-01-18 12:32                   ` André Przywara
2013-01-18 15:17                     ` Matthew Garrett
2013-01-18 15:26                       ` Borislav Petkov [this message]
2013-01-18 15:32                         ` Matthew Garrett
2013-01-18 17:10                           ` Borislav Petkov
2013-01-18 17:17                             ` Matthew Garrett
2013-01-19 12:08                       ` Borislav Petkov
2013-01-21  5:14                         ` Leonid Isaev
2013-01-21 10:54                           ` Borislav Petkov
2013-01-18 17:13                     ` Leonid Isaev
2013-01-18 16:59                   ` Leonid Isaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130118152633.GA4062@pd.tnic \
    --to=bp@alien8.de \
    --cc=andre@andrep.de \
    --cc=cpufreq@vger.kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lisaev@umail.iu.edu \
    --cc=matthew.garrett@nebula.com \
    --cc=rjw@sisk.pl \
    --cc=teg@jklm.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.