From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Millenbach <jmillenbach@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>, Jiri Slaby <jirislaby@gmail.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Jamey Sharp <jamey@minilop.net>
Subject: Re: [PATCHv4] tty: Added a CONFIG_TTY option to allow removal of TTY
Date: Fri, 18 Jan 2013 16:22:09 -0800 [thread overview]
Message-ID: <20130119002209.GA30107@kroah.com> (raw)
In-Reply-To: <1358491462-16562-1-git-send-email-jmillenbach@gmail.com>
On Thu, Jan 17, 2013 at 10:44:22PM -0800, Joe Millenbach wrote:
> The option allows you to remove TTY and compile without errors. This
> saves space on systems that won't support TTY interfaces anyway.
> bloat-o-meter output is below.
>
> The bulk of this patch consists of Kconfig changes adding "depends on
> TTY" to various serial devices and similar drivers that require the TTY
> layer. Ideally, these dependencies would occur on a common intermediate
> symbol such as SERIO, but most drivers "select SERIO" rather than
> "depends on SERIO", and "select" does not respect dependencies.
>
> bloat-o-meter output comparing our previous minimal to new minimal by
> removing TTY. The list is filtered to not show removed entries with awk
> '$3 != "-"' as the list was very long.
>
> add/remove: 0/226 grow/shrink: 2/14 up/down: 6/-35356 (-35350)
> function old new delta
> chr_dev_init 166 170 +4
> allow_signal 80 82 +2
> static.__warned 143 142 -1
> disallow_signal 63 62 -1
> __set_special_pids 95 94 -1
> unregister_console 126 121 -5
> start_kernel 546 541 -5
> register_console 593 588 -5
> copy_from_user 45 40 -5
> sys_setsid 128 120 -8
> sys_vhangup 32 19 -13
> do_exit 1543 1526 -17
> bitmap_zero 60 40 -20
> arch_local_irq_save 137 117 -20
> release_task 674 652 -22
> static.spin_unlock_irqrestore 308 260 -48
>
> Signed-off-by: Joe Millenbach <jmillenbach@gmail.com>
> Reviewed-by: Jamey Sharp <jamey@minilop.net>
Very nice, I've applied this to my tree now, thanks for doing this.
greg k-h
prev parent reply other threads:[~2013-01-19 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 6:44 [PATCHv4] tty: Added a CONFIG_TTY option to allow removal of TTY Joe Millenbach
2013-01-18 17:17 ` Josh Triplett
2013-01-19 0:22 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130119002209.GA30107@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=jamey@minilop.net \
--cc=jirislaby@gmail.com \
--cc=jmillenbach@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.