From: Cong Ding <dinggnu@gmail.com>
To: Jake Champlin <jake.champlin.27@gmail.com>
Cc: gregkh@linuxfoundation.org, sjening@linux.vnet.ibm.com,
konrad.wilk@oracle.com, xiaoguangrong@linux.vnet.ibm.com,
dan.magenheimer@oracle.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: zcache-main: Fixed Camel Case Issue
Date: Sat, 19 Jan 2013 04:08:27 +0100 [thread overview]
Message-ID: <20130119030826.GG18593@gmail.com> (raw)
In-Reply-To: <20130119025640.GA32271@gmail.com>
On Fri, Jan 18, 2013 at 09:56:44PM -0500, Jake Champlin wrote:
> Fixed a camel case coding style issue.
>
> Signed-off-by: Jake Champlin <jake.champlin.27@gmail.com>
> ---
> drivers/staging/zcache/zcache-main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
> index 52b43b7..95be348 100644
> --- a/drivers/staging/zcache/zcache-main.c
> +++ b/drivers/staging/zcache/zcache-main.c
> @@ -1851,7 +1851,7 @@ static int zcache_frontswap_store(unsigned type, pgoff_t offset,
> int ret = -1;
> unsigned long flags;
>
> - BUG_ON(!PageLocked(page));
> + BUG_ON(!page_locked(page));
> if (likely(ind64 == ind)) {
> local_irq_save(flags);
> ret = zcache_put_page(LOCAL_CLIENT, zcache_frontswap_poolid,
> @@ -1871,7 +1871,7 @@ static int zcache_frontswap_load(unsigned type, pgoff_t offset,
> struct tmem_oid oid = oswiz(type, ind);
> int ret = -1;
>
> - BUG_ON(!PageLocked(page));
> + BUG_ON(!page_locked(page));
again, that doesn't work. Did you try to build the code?
- cong
> if (likely(ind64 == ind))
> ret = zcache_get_page(LOCAL_CLIENT, zcache_frontswap_poolid,
> &oid, iswiz(ind), page);
> --
> 1.8.1.1
>
>
> --
> Jake Champlin
> jake.champlin.27@gmail.com
> 8123742937
> <MuttClient>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-01-19 3:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 2:56 [PATCH] Staging: zcache-main: Fixed Camel Case Issue Jake Champlin
2013-01-19 3:08 ` Cong Ding [this message]
2013-01-19 10:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130119030826.GG18593@gmail.com \
--to=dinggnu@gmail.com \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jake.champlin.27@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sjening@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.