From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 5/5] agp/intel: Add gma_bus_addr
Date: Fri, 18 Jan 2013 19:22:01 -0800
Message-ID: <20130119032201.GA1479@lundgren.kumite>
References: <1358540860-20181-1-git-send-email-ben@bwidawsk.net>
	<1358541034-20327-1-git-send-email-ben@bwidawsk.net>
	<1358541034-20327-4-git-send-email-ben@bwidawsk.net>
	<20130118211824.GX8347@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6632EE5C70
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 18 Jan 2013 19:20:46 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20130118211824.GX8347@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jan 18, 2013 at 10:18:24PM +0100, Daniel Vetter wrote:
> On Fri, Jan 18, 2013 at 12:30:34PM -0800, Ben Widawsky wrote:
> > It is no longer used in the i915 code, so isolate it from the shared
> > struct.
> > 
> > This was originally part of:
> > commit 0e275518f325418d559c05327775bff894b237f7
> > Author: Ben Widawsky <ben@bwidawsk.net>
> > Date:   Mon Jan 14 13:35:33 2013 -0800
> > 
> >     agp/intel: decouple more of the agp-i915 sharing
> > 
> >     Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> >     Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > 
> > That commit had some other hunks which can't be used due to issues
> > Daniel found in previous commits.
> > 
> > Recommend to squash this in to:
> > commit 42389dbda7398dac0ceadef327d51dc5509f9399
> > Author: Ben Widawsky <ben@bwidawsk.net>
> > Date:   Fri Jan 11 13:50:28 2013 -0800
> > 
> >     drm/i915: Remove use on gma_bus_addr on gen6+
> > 
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> 
> All slurped into dinq, thanks for the patches.
> -Daniel

It seems the accidentally dropped hunk you caught is indeed a problem on
my machine. I've submitted a patch to revert it.

Sorry.


-- 
Ben Widawsky, Intel Open Source Technology Center