From: Greg KH <gregkh@linuxfoundation.org>
To: Jake Champlin <jake.champlin.27@gmail.com>
Cc: devel@driverdev.osuosl.org, sjenning@linux.vnet.ibm.com,
dan.magenheimer@oracle.com, konrad.wilk@oracle.com,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] Staging: ramster: zcache-main: Fixed Bracing Issues
Date: Sun, 20 Jan 2013 15:59:45 -0800 [thread overview]
Message-ID: <20130120235945.GA29683@kroah.com> (raw)
In-Reply-To: <20130119040950.GA18812@gmail.com>
On Fri, Jan 18, 2013 at 11:09:56PM -0500, Jake Champlin wrote:
> Fixed Coding Style Bracing Issues
>
> Signed-off-by: Jake Champlin <jake.champlin.27@gmail.com>
> ---
> drivers/staging/ramster/zcache-main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ramster/zcache-main.c b/drivers/staging/ramster/zcache-main.c
> index a09dd5c..2613889 100644
> --- a/drivers/staging/ramster/zcache-main.c
> +++ b/drivers/staging/ramster/zcache-main.c
> @@ -478,6 +478,7 @@ static void zcache_free_page(struct page *page)
> #ifdef ZCACHE_DEBUG
> if (curr_pageframes > 2L || curr_pageframes < -2L) {
> /* pr_info here */
> + /* unnecessary comment */
> }
> #endif
> }
That doesn't look like it is fixing any coding style issues, you just
added a comment for no reason?
I understand it will shut checkpatch.pl up, but be reasonable here
please, it's a tool to be used as a guideline, use your judgement
please.
greg k-h
prev parent reply other threads:[~2013-01-20 23:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 4:09 [PATCH] Staging: ramster: zcache-main: Fixed Bracing Issues Jake Champlin
2013-01-20 23:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130120235945.GA29683@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=jake.champlin.27@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.