From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: thoughts on requiring multi-arch support for arm drm drivers? Date: Mon, 21 Jan 2013 08:17:35 +0100 Message-ID: <20130121071735.GC15508@avionic-0098.adnet.avionic-design.de> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0697199166==" Return-path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.10]) by gabe.freedesktop.org (Postfix) with ESMTP id DAAABE6108 for ; Sun, 20 Jan 2013 23:17:39 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: Daniel Vetter , Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0697199166== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IpbVkmxF4tDyP/Kb" Content-Disposition: inline --IpbVkmxF4tDyP/Kb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 20, 2013 at 09:08:34AM -0600, Rob Clark wrote: > One thing I've run into in the past when trying to make changes in drm > core, and Daniel Vetter has mentioned the same, is that it is a bit of > a pain to compile test things for the arm drivers that do not support > CONFIG_ARCH_MULTIPLATFORM. I went through a while back and fixed up > the low hanging fruit (basically the drivers that just needed a > Kconfig change). But, IIRC some of the backlight related code in > shmob had some non-trivial plat dependencies. And I think when tegra > came in, it introduced some non-trivial plat dependencies. I've talked to Stephen about this a few days ago and his (tentative) plan is to support ARCH_MULTIPLATFORM in 3.9. I'm not sure if that's soon enough for you. I think the one remaining platform dependency is the tegra_periph_reset_{assert,deassert}() which should be gone with the common clock framework changes which should go into 3.9. Stephen has other work-in-progress patches for the rest, so I think chances are actually pretty good to get this ready for 3.9. > What do others think about requiring multiarch or no arch dependencies > for new drivers, and cleaning up existing drivers. Even if it is at > reduced functionality (like maybe #ifdef CONFIG_ARCH_SHMOBILE for some > of the backlight code in shmob) or doesn't even work but is just for > the purpose of being able to compile test the rest of the code? I imagine that on Tegra we could add dummy implementations for the reset functions, which should allow it to build it for non-Tegra. However, I don't think it's really worth the churn to do this now just to remove them again in 3.9. The general direction would seem to be to require new platforms to be multi-platform from the start, so any new drivers should not cause the same pain anyway. Thierry --IpbVkmxF4tDyP/Kb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQ/OuPAAoJEN0jrNd/PrOhBo8P/Rp8ilnPGuzDfASqdZHVyFl4 YOqB+OCdEZDjEym5Tl8c/vmJZo4NUQbGNww+4uLrKcc33/uCBpC4/AyNAP/EGjHh EFvXjhM46axW0oULeQbwitBWm4BKtaggcyd17Im1Naf4KmtPy6hg1QWM2pB1/e3g LtkNdC7DwoVnW4FaLiUdxpwZ2U11CUnWhhJtdnGbHDRL3/tIBkpBtvAKXsGq/Kgg aLtrPYxcmTOG33CWqPYAFa/lpNYEYHNPA1kI/PkDS2bsXn8PQA65qgB7HTzgbNpi esNJtUf2oFfxlLhaoli3dfYyEo71zU2mOGM7VcEMoEBNqUOq6cy4AFgKQfBkH1ZU 2oBmNmo1GaxtbSGY0iA1YJs50U59rmGRlCMtulsu0Dcvh1MHd2lVrU7jfx4ByhV0 RLP3ICuCsfwmFHq01C0C9vgvVQFYqgOs/MvgYyoxK6RecLbXtIEZqEMXiQHwf3D0 +9u9+dIRJ7HACUQRpJY/abRbYatSlI7t0FoPgTJhHulV5RK62//WrfIE5FU1NKlk 8qJx1FzBt1LL6E5A2Vk2vlppiW8LOQO/6OjmNkHZ584FgJePGWsEnPbJcSRnSwOp K/5G4m88E9Dh1qlCZ63zW/+J10pz0OZVpZ8cvJwuEMKC1eT6en1WRA52Hr96wnPR YOlAOa7JazxXANVqnRlg =59rJ -----END PGP SIGNATURE----- --IpbVkmxF4tDyP/Kb-- --===============0697199166== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0697199166==--