Re: [Qemu-devel] [PATCH 3/3] net/bitbang_mdio: Use bitbang core for smc91c111 network device

[Grant Likely <grant.likely@secretlab.ca>]

On Sun, 20 Jan 2013 11:29:32 +0000, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 19 January 2013 22:28, Grant Likely <grant.likely@secretlab.ca> wrote:
> > The smc91c111 device has bitbanged MDIO access, but the model doesn't
> > yet implement it. This patch uses the generalized bitbang MDIO support
> > pulled out of etraxfs Ethernet driver.
> 
> > @@ -44,6 +45,13 @@ typedef struct {
> >      uint8_t int_level;
> >      uint8_t int_mask;
> >      MemoryRegion mmio;
> > +
> > +    /* MDIO bus.  */
> > +    struct qemu_mdio mdio_bus;
> > +    unsigned int phyaddr;
> > +
> > +    /* PHY. */
> > +    struct qemu_phy phy;
> >  } smc91c111_state;
> 
> This surely needs VMState additions so the extra state can be passed
> across migrations. It looks like the MDIO/PHY stuff from the etraxfs code
> doesn't have any kind of state save/restore support, so you probably need
> to first implement that in your new mdio/phy source file, and then refer
> to it here.

Ah, I see. I missed that. I will figure out how to do that and add it to
the next version.

g.