From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
chao.bi@intel.com
Subject: Re: [PATCH v2 06/10] spi/pxa2xx: add support for DMA engine
Date: Mon, 21 Jan 2013 18:14:01 +0200 [thread overview]
Message-ID: <20130121161400.GW2239@intel.com> (raw)
In-Reply-To: <20130121154436.GL23505@n2100.arm.linux.org.uk>
On Mon, Jan 21, 2013 at 03:44:36PM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 21, 2013 at 11:31:59AM +0200, Mika Westerberg wrote:
> > +bool dma_is_possible(size_t len)
> > +int map_dma_buffers(struct driver_data *drv_data)
> > +irqreturn_t dma_transfer(struct driver_data *drv_data)
> > +int dma_prepare(struct driver_data *drv_data, u32 dma_burst)
> > +void dma_start(struct driver_data *drv_data)
> > +int dma_setup(struct driver_data *drv_data)
> > +void dma_release(struct driver_data *drv_data)
> > +void dma_resume(struct driver_data *drv_data)
> > +int set_dma_burst_and_threshold(struct chip_data *chip,
> > + struct spi_device *spi,
> > + u8 bits_per_word, u32 *burst_code,
> > + u32 *threshold)
>
> All the above function names end up in the global namespace in the kernel
> image. They're rather _too_ generic and non-specific for them to leak to
> that visibility. I think this needs fixing.
Indeed, good point. I will fix this.
> Also, I'd suggest that the long term plan is for PXA to move over to the
> DMA engine API, so I'd recommend that the pxa2xx SPI driver have the
> DMA engine API usage built into it, and let's treat the old PXA DMA
> stuff as legacy code.
In the previous version I had the old PXA DMA stuff behind #ifdef
CONFIG_ARCH_PXA and otherwise it used the DMA engine stuff. Do you mean
something like that (e.g keep both DMA in the single file)?
next prev parent reply other threads:[~2013-01-21 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 9:31 [PATCH v2 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support Mika Westerberg
2013-01-21 9:31 ` [PATCH v2 01/10] spi/pxa2xx: allow building on a 64-bit kernel Mika Westerberg
2013-01-21 9:31 ` [PATCH v2 02/10] spi/pxa2xx: fix warnings when compiling " Mika Westerberg
2013-01-21 10:01 ` Andy Shevchenko
2013-01-21 9:31 ` [PATCH v2 03/10] spi/pxa2xx: convert to the pump message infrastructure Mika Westerberg
2013-01-21 9:31 ` [PATCH v2 04/10] spi/pxa2xx: convert to the common clk framework Mika Westerberg
2013-01-21 9:31 ` [PATCH v2 05/10] spi/pxa2xx: use the private DMA API only when CONFIG_ARCH_PXA is set Mika Westerberg
2013-01-21 9:31 ` [PATCH v2 06/10] spi/pxa2xx: add support for DMA engine Mika Westerberg
2013-01-21 15:44 ` Russell King - ARM Linux
2013-01-21 16:14 ` Mika Westerberg [this message]
2013-01-21 9:32 ` [PATCH v2 07/10] spi/pxa2xx: add support for runtime PM Mika Westerberg
2013-01-21 9:32 ` [PATCH v2 08/10] spi/pxa2xx: add support for SPI_LOOP Mika Westerberg
2013-01-21 9:32 ` [PATCH v2 09/10] spi/pxa2xx: add support for Intel Low Power Subsystem SPI Mika Westerberg
2013-01-21 9:32 ` [PATCH v2 10/10] spi/pxa2xx: add support for Lynxpoint SPI controllers Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130121161400.GW2239@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=chao.bi@intel.com \
--cc=eric.y.miao@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.