From: Cyrill Gorcunov <gorcunov@openvz.org>
To: "Steven L. Kinney" <steven.kinney@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Joerg Roedel <joro@8bytes.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
Myron Stowe <myron.stowe@redhat.com>,
Hiroshi DOYU <hdoyu@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Jiri Kosina <jkosina@suse.cz>, Kukjin Kim <kgene.kim@samsung.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Thomas Renninger <trenn@suse.de>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/3] AMD IOMMUv2 PC resource management hooks
Date: Tue, 22 Jan 2013 01:32:18 +0400 [thread overview]
Message-ID: <20130121213218.GI25252@moon> (raw)
In-Reply-To: <1358799658-6236-3-git-send-email-steven.kinney@amd.com>
On Mon, Jan 21, 2013 at 02:20:57PM -0600, Steven L. Kinney wrote:
> +u8 amd_iommu_v2_get_max_pc_banks(u16 devid)
> +{
> + struct amd_iommu *iommu;
> +
> + /* locate the iommu governing the devid */
> + iommu = amd_iommu_rlookup_table[devid];
> +
> + if (iommu)
> + return iommu->max_banks;
> +
> + return -ENODEV;
> +}
> +EXPORT_SYMBOL(amd_iommu_v2_get_max_pc_banks);
Hi Steven, may not it be better to return int here, instead of u8?
next prev parent reply other threads:[~2013-01-21 21:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 20:20 [PATCH 0/3] AMD IOMMUv2 Performance Counter patches Steven L. Kinney
2013-01-21 20:20 ` Steven L. Kinney
[not found] ` <1358799658-6236-1-git-send-email-steven.kinney-5C7GfCeVMHo@public.gmane.org>
2013-01-21 20:20 ` [PATCH 1/3] AMD x86 quirks: Quirk for enabling IOMMUv2 PC feature Steven L. Kinney
2013-01-21 20:20 ` Steven L. Kinney
[not found] ` <1358799658-6236-2-git-send-email-steven.kinney-5C7GfCeVMHo@public.gmane.org>
2013-01-28 14:29 ` Joerg Roedel
2013-01-28 14:29 ` Joerg Roedel
2013-01-28 14:59 ` Kinney, Steven
[not found] ` <57D41218901B4442B4AFF404D21591163C2D4E-Vo+W8YXarribnmZ2XWmV+UEOCMrvLtNR@public.gmane.org>
2013-01-28 15:36 ` Joerg Roedel
2013-01-28 15:36 ` Joerg Roedel
2013-01-21 20:20 ` [PATCH 2/3] AMD IOMMUv2 PC resource management hooks Steven L. Kinney
2013-01-21 20:20 ` Steven L. Kinney
2013-01-21 21:32 ` Cyrill Gorcunov [this message]
2013-01-21 21:47 ` Kinney, Steven
2013-01-21 21:47 ` Kinney, Steven
2013-01-21 21:52 ` Cyrill Gorcunov
2013-01-21 20:20 ` [PATCH 3/3] AMD IOMMUv2 PC perf PMU implementation Steven L. Kinney
2013-01-21 20:20 ` Steven L. Kinney
2013-01-22 17:48 ` [PATCH 0/3] AMD IOMMUv2 Performance Counter patches Konrad Rzeszutek Wilk
2013-01-22 17:48 ` Konrad Rzeszutek Wilk
[not found] ` <20130122174803.GF8365-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2013-01-22 18:26 ` Kinney, Steven
2013-01-22 18:26 ` Kinney, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130121213218.GI25252@moon \
--to=gorcunov@openvz.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=ak@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdoyu@nvidia.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=joro@8bytes.org \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=myron.stowe@redhat.com \
--cc=paulus@samba.org \
--cc=sebastian@breakpoint.cc \
--cc=steven.kinney@amd.com \
--cc=swarren@wwwdotorg.org \
--cc=tglx@linutronix.de \
--cc=trenn@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.