From: Samuel Ortiz <sameo@linux.intel.com>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@avionic-design.de>
Subject: Re: [PATCH v2 2/2] backlight: add new lp8788 backlight driver
Date: Tue, 22 Jan 2013 01:32:40 +0100 [thread overview]
Message-ID: <20130122003240.GD7409@sortiz-mobl> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F69E108D2@DQHE02.ent.ti.com>
Hi,
On Fri, Dec 21, 2012 at 07:55:23AM +0000, Kim, Milo wrote:
> TI LP8788 PMU supports regulators, battery charger, RTC, ADC, backlight driver
> and current sinks.
> This patch enables LP8788 backlight module.
>
> (Brightness mode)
> The brightness is controlled by PWM input or I2C register.
> All modes are supported in the driver.
>
> (Platform data)
> Configurable data can be defined in the platform side.
> name : backlight driver name. (default: "lcd-backlight")
> initial_brightness : initial value of backlight brightness
> bl_mode : brightness control by PWM or lp8788 register
> dim_mode : dimming mode selection
> full_scale : full scale current setting
> rise_time : brightness ramp up step time
> fall_time : brightness ramp down step time
> pwm_pol : PWM polarity setting when bl_mode is PWM based
> period_ns : platform specific PWM period value. unit is nano.
>
> The default values are set in case no platform data is defined.
>
> Patch v2.
> use generic PWM functions rather than lp8788 platform data function calls.
> add configurable PWM period in the platform data.
> replace module_init() and module_exit() with module_platform_driver().
>
> Patch v1.
> initial patch
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
> drivers/video/backlight/Kconfig | 6 +
> drivers/video/backlight/Makefile | 1 +
> drivers/video/backlight/lp8788_bl.c | 350 +++++++++++++++++++++++++++++++++++
> include/linux/mfd/lp8788.h | 16 +-
For the MFD parts:
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2013-01-22 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 7:55 [PATCH v2 2/2] backlight: add new lp8788 backlight driver Kim, Milo
2012-12-21 22:28 ` Andrew Morton
2013-01-03 8:08 ` Thierry Reding
2013-01-03 8:54 ` Kim, Milo
2013-01-03 9:05 ` Thierry Reding
2013-01-22 0:32 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122003240.GD7409@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=Milo.Kim@ti.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.