From: Samuel Ortiz <sameo@linux.intel.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Chiwoong Byun <woong.byun@samsung.com>,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: max77693: Init max77693->dev before using it
Date: Tue, 22 Jan 2013 04:30:53 +0100 [thread overview]
Message-ID: <20130122033053.GW7409@sortiz-mobl> (raw)
In-Reply-To: <1356366516.17063.5.camel@phoenix>
Hi Axel,
On Tue, Dec 25, 2012 at 12:28:36AM +0800, Axel Lin wrote:
> Current code uses max77693->dev in the dev_err call before setting it to
> &i2c->dev. Fix it.
>
> This patch also includes below cleanups:
> - Move checking pdata earlier and show dev_err if no platform data found.
> - Remove unnecessary err_regmap goto label.
> - Unregister i2c devices if regmap init for muic fails.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/max77693.c | 34 ++++++++++++++++++----------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
Applied as well, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-01-22 3:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 16:16 [PATCH 1/2] mfd: max77686: Init max77686->dev before using it Axel Lin
2012-12-24 16:28 ` [PATCH 2/2] mfd: max77693: Init max77693->dev " Axel Lin
2013-01-22 3:30 ` Samuel Ortiz [this message]
2013-01-22 3:24 ` [PATCH 1/2] mfd: max77686: Init max77686->dev " Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122033053.GW7409@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=axel.lin@ingics.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=woong.byun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.