From: Tony Lindgren <tony@atomide.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Cong Ding <dinggnu@gmail.com>, Joerg Roedel <joro@8bytes.org>,
Omar Ramirez Luna <omar.luna@linaro.org>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iommu: omap-iommu.c: remove unnecessary null pointer check
Date: Tue, 22 Jan 2013 12:17:53 -0800 [thread overview]
Message-ID: <20130122201752.GS22517@atomide.com> (raw)
In-Reply-To: <CAK=WgbbW+Kje8fMNmSAy+qM6sLcoqZcLcev8w115BfGrQzHk2A@mail.gmail.com>
* Ohad Ben-Cohen <ohad@wizery.com> [130118 12:58]:
> On Fri, Jan 18, 2013 at 10:42 PM, Cong Ding <dinggnu@gmail.com> wrote:
> > The pointer obj is dereferenced in line 146 and 149 respectively, so it is not
> > necessary to check null again in line 149 and 175. And I have checked that all
> > the callers of these two functions guarantee the parameter obj passed is not
> > null.
> >
> > Signed-off-by: Cong Ding <dinggnu@gmail.com>
>
> Acked-by: Ohad Ben-Cohen <ohad@wizery.com>
Yes looks like that's a pointless check and would already obj being NULL would
fail earlier in those functions:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2013-01-22 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 20:42 [PATCH] iommu: omap-iommu.c: remove unnecessary null pointer check Cong Ding
2013-01-18 20:55 ` Ohad Ben-Cohen
2013-01-22 20:17 ` Tony Lindgren [this message]
2013-01-28 14:22 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122201752.GS22517@atomide.com \
--to=tony@atomide.com \
--cc=dinggnu@gmail.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=ohad@wizery.com \
--cc=omar.luna@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.