From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Martin Date: Tue, 22 Jan 2013 15:06:32 -0800 Subject: [U-Boot] [PATCH] sandbox: fix compiler warning In-Reply-To: References: <1358890962-24866-1-git-send-email-amartin@nvidia.com> <20130122224847.GA23767@badger> Message-ID: <20130122230631.GB23767@badger> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jan 22, 2013 at 02:58:58PM -0800, Simon Glass wrote: > Hi Allen, > > On Tue, Jan 22, 2013 at 2:48 PM, Allen Martin wrote: > > On Tue, Jan 22, 2013 at 01:56:23PM -0800, Simon Glass wrote: > >> On Tue, Jan 22, 2013 at 1:42 PM, Allen Martin wrote: > >> > Fix compiler warning about control flow reaching end of non void > >> > function. > >> > > >> > Signed-off-by: Allen Martin > >> > >> Should perhaps mention the commit that adding this warning (e05e5de7 I think) > >> > >> Acked-by: Simon Glass > >> > > > > It was this commit: > > > > commit fec79acc864bed049b6beae719ccbf2bbec5403a > > Author: Mike Frysinger > > Date: Wed Oct 26 00:22:14 2011 +0000 > > > > sandbox: drop unused return > > > > Signed-off-by: Mike Frysinger > > Acked-by: Simon Glass > > > > > > I'll change the commit messagen and repost and cc Mike as well. > > Actually I think that Mike's commit was correct at the time, and it > was Albert's which changed the no-return behaviour of the function > signature in common.h? Oh I see, you're right. I'll resend. -Allen -- nvpublic