From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: thoughts on requiring multi-arch support for arm drm drivers? Date: Wed, 23 Jan 2013 08:39:57 +0100 Message-ID: <20130123073957.GS1906@pengutronix.de> References: <8768912.0nxCOnSEOC@avalon> <3579832.etYhVaEi7B@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [92.198.50.35]) by gabe.freedesktop.org (Postfix) with ESMTP id 1971CE5C9A for ; Tue, 22 Jan 2013 23:40:01 -0800 (PST) Content-Disposition: inline In-Reply-To: <3579832.etYhVaEi7B@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Laurent Pinchart Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Jan 23, 2013 at 02:29:25AM +0100, Laurent Pinchart wrote: > Hi Rob, > > On Monday 21 January 2013 09:54:01 Rob Clark wrote: > > On Mon, Jan 21, 2013 at 9:47 AM, Laurent Pinchart wrote: > > > On Sunday 20 January 2013 09:08:34 Rob Clark wrote: > > >> One thing I've run into in the past when trying to make changes in drm > > >> core, and Daniel Vetter has mentioned the same, is that it is a bit of > > >> a pain to compile test things for the arm drivers that do not support > > >> CONFIG_ARCH_MULTIPLATFORM. I went through a while back and fixed up > > >> the low hanging fruit (basically the drivers that just needed a > > >> Kconfig change). But, IIRC some of the backlight related code in > > >> shmob had some non-trivial plat dependencies. > > > > > > I've just compiled the shmob-drm driver without any error on x86_64. The > > > CMA GEM helpers don't compile due to missing > > > dma_(alloc|free)_writecombine though (but that would only be an issue if > > > we require no arch dependency at all, not with multiarch). > > > > ahh, ok.. maybe I should try again. I'm pretty sure I was hitting > > some issues around the backlight code before, but maybe that has been > > fixed since then. > > > > Anyways, if it builds for multi-platform, maybe you could send a patch > > for the kconfig? > > Do you prefer a dependency on (ARM || SUPERH) or (ARCH_MULTIPLATFORM || > SUPERH) ? I suggest ARM instead of ARCH_MULTIPLATFORM since the former is the real requirement for being able to compile it. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |