From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Fabio Estevam
<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH] i2c: i2c-mxs: Fix type of error code
Date: Wed, 23 Jan 2013 12:01:51 +0100 [thread overview]
Message-ID: <201301231201.51675.marex@denx.de> (raw)
In-Reply-To: <20130123095314.GA3767-8EAEigeeuNG034pCzgS/Qg7AFbiQbgqx@public.gmane.org>
Dear Wolfram Sang,
> On Mon, Jan 07, 2013 at 10:32:06PM -0200, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >
> > cmd_err is used to handle error code, so it should not be unsigned.
> >
> > This fixes the following warning when building with W=1 option:
> >
> > drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg':
> > drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed
> > and unsigned integer expressions [-Wsign-compare]
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> Thanks! Applied to current and added stable.
I dont wanna be nagging, but you polling the linux-i2c stuff every 3 months or
so doesn't make the development all that smooth. Btw. there are other patches
(like the speed patch, like the pio/dma patch) which still keep hanging. I'd
like to see them in 3.8, since they were submitted nearly three months ago.
I even bumped you about them every so often. Can you go through your mailbox
please?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-01-23 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 0:32 [PATCH] i2c: i2c-mxs: Fix type of error code Fabio Estevam
[not found] ` <1357605126-26537-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-08 6:57 ` Marek Vasut
2013-01-23 9:53 ` Wolfram Sang
[not found] ` <20130123095314.GA3767-8EAEigeeuNG034pCzgS/Qg7AFbiQbgqx@public.gmane.org>
2013-01-23 11:01 ` Marek Vasut [this message]
[not found] ` <201301231201.51675.marex-ynQEQJNshbs@public.gmane.org>
2013-01-23 11:10 ` Wolfram Sang
[not found] ` <20130123111039.GD16264-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-23 11:26 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301231201.51675.marex@denx.de \
--to=marex-ynqeqjnshbs@public.gmane.org \
--cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.