From: Timo Teras <timo.teras@iki.fi>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] r8169: remove the obsolete and incorrect AMD workaround
Date: Thu, 24 Jan 2013 08:09:11 +0200 [thread overview]
Message-ID: <20130124080911.31d52da9@vostro> (raw)
In-Reply-To: <20130123223834.GA5124@electric-eye.fr.zoreil.com>
On Wed, 23 Jan 2013 23:38:34 +0100 Francois Romieu
<romieu@fr.zoreil.com> wrote:
> Timo Teras <timo.teras@iki.fi> :
> [...]
> > Actually, this sounds wrong. Why is rtl8169_rx_vlan_tag() which is
> > fiddling opts2 invoked *after* rtl8169_mark_to_asic() ? This means
> > it can overwrite the tag info if the queue is full.
>
> Yes. It has been there for ages.
>
> What about something like the patch below ?
Looks good as the minimum intrusion for stable branches. Though, I'm
wondering if it'd be easy to refactor rtl_rx() so that it would
not need that many goto labels.
next prev parent reply other threads:[~2013-01-24 6:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 15:12 r8169 doing more work than napi weight Timo Teras
2013-01-21 23:42 ` Francois Romieu
2013-01-22 8:30 ` [PATCH net] r8169: remove the obsolete and incorrect AMD workaround Timo Teräs
2013-01-23 0:05 ` Francois Romieu
2013-01-23 0:42 ` David Miller
2013-01-23 6:14 ` Timo Teras
2013-01-23 22:38 ` Francois Romieu
2013-01-24 6:09 ` Timo Teras [this message]
2013-01-23 18:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124080911.31d52da9@vostro \
--to=timo.teras@iki.fi \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.