diff for duplicates of <20130124090101.GC4584@mwanda> diff --git a/a/1.txt b/N1/1.txt index f0337de..da77ed1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -21,7 +21,7 @@ On Thu, Jan 24, 2013 at 09:22:56AM +0100, walter harms wrote: > > + /* "pim6reg%u" should not exceed 16 bytes (IFNAMSIZ) */ > > + if (v != RT_TABLE_DEFAULT && v >= 100000000) > > + return -EINVAL; -> > if (sk = mrt->mroute6_sk) +> > if (sk == mrt->mroute6_sk) > > return -EBUSY; > > > hi Dan, @@ -31,7 +31,7 @@ On Thu, Jan 24, 2013 at 09:22:56AM +0100, walter harms wrote: Yes. > also the if is a bit strange, i assume that RT_TABLE_DEFAULT is const -> so anything else is rejected than v=RT_TABLE_DEFAULT +> so anything else is rejected than v==RT_TABLE_DEFAULT > (assuming that RT_TABLE_DEFAULT >= 100000000 ....) I don't understand what you are saying. @@ -40,7 +40,7 @@ The patch is basically copy and pasted from b49d3c1e1c "net: ipmr: limit MRT_TABLE identifiers". RT6_TABLE_DFLT is allowed to be a high number because in ip6mr_reg_vif() we do: - if (mrt->id = RT6_TABLE_DFLT) + if (mrt->id == RT6_TABLE_DFLT) sprintf(name, "pim6reg"); else sprintf(name, "pim6reg%u", mrt->id); diff --git a/a/content_digest b/N1/content_digest index 6dcdd4f..f1b4502 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\05100EF60.1080409@bfs.de\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [patch] ip6mr: limit IPv6 MRT_TABLE identifiers\0" - "Date\0Thu, 24 Jan 2013 09:01:01 +0000\0" + "Date\0Thu, 24 Jan 2013 12:01:01 +0300\0" "To\0walter harms <wharms@bfs.de>\0" "Cc\0David S. Miller <davem@davemloft.net>" Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> @@ -36,7 +36,7 @@ "> > +\t\t/* \"pim6reg%u\" should not exceed 16 bytes (IFNAMSIZ) */\n" "> > +\t\tif (v != RT_TABLE_DEFAULT && v >= 100000000)\n" "> > +\t\t\treturn -EINVAL;\n" - "> > \t\tif (sk = mrt->mroute6_sk)\n" + "> > \t\tif (sk == mrt->mroute6_sk)\n" "> > \t\t\treturn -EBUSY;\n" "> > \n" "> hi Dan,\n" @@ -46,7 +46,7 @@ "Yes.\n" "\n" "> also the if is a bit strange, i assume that RT_TABLE_DEFAULT is const\n" - "> so anything else is rejected than v=RT_TABLE_DEFAULT\n" + "> so anything else is rejected than v==RT_TABLE_DEFAULT\n" "> (assuming that RT_TABLE_DEFAULT >= 100000000 ....)\n" "\n" "I don't understand what you are saying.\n" @@ -55,7 +55,7 @@ "limit MRT_TABLE identifiers\". RT6_TABLE_DFLT is allowed to be a\n" "high number because in ip6mr_reg_vif() we do:\n" "\n" - " if (mrt->id = RT6_TABLE_DFLT)\n" + " if (mrt->id == RT6_TABLE_DFLT)\n" " sprintf(name, \"pim6reg\");\n" " else\n" " sprintf(name, \"pim6reg%u\", mrt->id);\n" @@ -63,4 +63,4 @@ "regards,\n" dan carpenter -193f65ffccd7c0fc130df5ba8aa1665528e6e3de82f51301ff053bba0ee33bbb +d0dabe4c80f093b948435f0e3fc7030ca0ac35d1af599f5a443a26457f25cf50
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.