All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kyle McMartin <kyle@redhat.com>,
	linux-kernel@vger.kernel.org, mingo@redhat.com
Subject: Re: [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL
Date: Thu, 24 Jan 2013 11:18:54 +0100	[thread overview]
Message-ID: <20130124101854.GC27602@gmail.com> (raw)
In-Reply-To: <20130123140440.8a4b1e3f.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 22 Jan 2013 14:21:03 -0500
> Kyle McMartin <kyle@redhat.com> wrote:
> 
> > CONFIG_EXPERT is a bit silly a place for this, and hides it
> > unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.
> > 
> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
> > 
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
> >  	default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
> >  
> >  config PANIC_ON_OOPS
> > -	bool "Panic on Oops" if EXPERT
> > +	bool "Panic on Oops" if DEBUG_KERNEL
> >  	default n
> >  	help
> >  	  Say Y here to enable the kernel to panic when it oopses. This
> 
> hm, I'm not sure that it should depend on anything.  Where's the benefit?

Agreed.

(The 'default n' is superfuous as well, while at it.)

Thanks,

	Ingo

  reply	other threads:[~2013-01-24 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22 19:21 [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL Kyle McMartin
2013-01-23 22:04 ` Andrew Morton
2013-01-24 10:18   ` Ingo Molnar [this message]
2013-01-24 19:43     ` [PATCH] unhide CONFIG_PANIC_ON_OOPS Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130124101854.GC27602@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=kyle@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.