All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Tony Lindgren <tony@atomide.com>, Daniel Mack <zonque@gmail.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	eballetbo@gmail.com, javier.martinez@collabora.co.uk,
	ezequiel.garcia@free-electrons.com,
	spi-devel-general@lists.sourceforge.net,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] spi: spi-omap2-mcspi.c: Toggle CS after each word
Date: Thu, 24 Jan 2013 19:06:52 +0800	[thread overview]
Message-ID: <20130124110648.GM4955@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1358964529-4905-1-git-send-email-matthias.bgg@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

On Wed, Jan 23, 2013 at 07:08:49PM +0100, Matthias Brugger wrote:
> This patch allows the board code to define SPI devices which needs to
> toggle the chip select after every word send. This is needed to get a
> better resolution reading e.g. an ADC data stream.
> Apart from that, as in the normal code CS is controlled by software,
> a transfer is done much faster.

As Jarkko says the feature itself seems fine and the coding style fix
seems fine but they should really be separate changes.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-01-24 11:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 18:08 [PATCH 3/3] spi: spi-omap2-mcspi.c: Toggle CS after each word Matthias Brugger
2013-01-24  7:38 ` Jarkko Nikula
2013-01-24 11:06 ` Mark Brown [this message]
2013-01-24 22:19 ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130124110648.GM4955@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=eballetbo@gmail.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=tony@atomide.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.