Re: [RFC PATCH 3/16]: PVH xen: Add PHYSDEVOP_map_iomem

[Tim Deegan <tim@xen.org>]

At 17:32 -0800 on 11 Jan (1357925563), Mukesh Rathor wrote:
> In this patch, we define PHYSDEVOP_map_iomem and add support for
> it. Also, XEN_DOMCTL_memory_mapping code is put into a function so it
> can be shared later for PVH. No change in XEN_DOMCTL_memory_mapping
> functionality. 
> 
> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
> 
> diff -r ede1afe68962 -r 93d95f6dd693 xen/arch/x86/domctl.c
> diff -r ede1afe68962 -r 93d95f6dd693 xen/include/public/physdev.h
> --- a/xen/include/public/physdev.h	Fri Jan 11 16:20:38 2013 -0800
> +++ b/xen/include/public/physdev.h	Fri Jan 11 16:22:57 2013 -0800
> @@ -330,6 +330,19 @@ struct physdev_dbgp_op {
>  typedef struct physdev_dbgp_op physdev_dbgp_op_t;
>  DEFINE_XEN_GUEST_HANDLE(physdev_dbgp_op_t);
>  
> + 
> +#define PHYSDEVOP_map_iomem        30
> +struct physdev_map_iomem {
> +    /* IN */
> +    unsigned long first_gfn;
> +    unsigned long first_mfn;
> +    unsigned int nr_mfns;
> +    unsigned int add_mapping;        /* 1 == add mapping;  0 == unmap */
> +
> +};
> +typedef struct physdev_map_iomem physdev_map_iomem_t;
> +DEFINE_XEN_GUEST_HANDLE(physdev_map_iomem_t);
> +

This needs documentation.  Also, the arguemnts should be explicitly
sized to avoid compat difficulties. 

Tim.