From: Alan Cox <alan@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] goldfish: virtual input event driver
Date: Thu, 24 Jan 2013 17:16:42 +0000 [thread overview]
Message-ID: <20130124171642.387d7e40@bob.linux.org.uk> (raw)
In-Reply-To: <20130124041547.GB7112@core.coreip.homeip.net>
On Wed, 23 Jan 2013 20:15:47 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> Hi Alan,
>
> On Wed, Jan 23, 2013 at 05:38:43PM +0000, Alan Cox wrote:
> > From: Brian Swetland <swetland@google.com>
> >
> > This device is a direct pipe from "hardware" to the input
> > event subsystem, allowing us to avoid having to route
> > "keypad" style events through an AT keyboard driver (gross!)
> >
> > As with the other submissions this driver is cross architecture.
> >
> > Signed-off-by: Mike A. Chan <mikechan@google.com>
> > [Tided up to work on x86]
> > Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> > Signed-off-by: Yunhong Jiang <yunhong.jiang@intel.com>
> > Signed-off-by: Xiaohui Xin <xiaohui.xin@intel.com>
> > Signed-off-by: Jun Nakajima <jun.nakajima@intel.com>
> > Signed-off-by: Bruce Beare <bruce.j.beare@intel.com>
> > [Ported to 3.4]
> > Signed-off-by: Tom Keel <thomas.keel@intel.com>
> > [Cleaned up for 3.7 and submission]
> > Signed-off-by: Alan Cox <alan@linux.intel.com>
>
> I do not have drivers/tty/goldfish.c so I dropped that change... I
> also had a few more cleanups, the result is below.
Looks good to me - I wasn't sure about the remove method so I copied
the other keyboard drivers that still had one even though they used
devm_ methods for the allocation.
Alan
next prev parent reply other threads:[~2013-01-24 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 17:38 [PATCH] goldfish: virtual input event driver Alan Cox
2013-01-24 4:15 ` Dmitry Torokhov
2013-01-24 17:16 ` Alan Cox [this message]
2013-01-24 17:04 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2013-01-21 23:45 Alan Cox
2013-01-22 9:52 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124171642.387d7e40@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.