From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: call WARN_ON after the debug message
Date: Thu, 24 Jan 2013 14:54:58 -0500 [thread overview]
Message-ID: <20130124195458.GD9477@thunk.org> (raw)
In-Reply-To: <1359045044-31435-1-git-send-email-lczerner@redhat.com>
On Thu, Jan 24, 2013 at 05:30:43PM +0100, Lukas Czerner wrote:
> In two places we call WARN_ON() before we print out the debug message,
> however the custom is to print such messages before we call WARN_ON() so
> change that.
>
> Also use ext4_msg() instead of plain printk().
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
I was actually thinking about removing the WARN_ON entirely, or at
least suppressing it when the error begin returned from
ext4_map_blocks is EIO. The reason for that is the warning is causing
noise for automated log scanners, and if the problem is caused by a
hardware failure, there's no real point in dumping out a stack trace.
More generally, is there any reason why we need the stack trace at
all?
Also maybe we should use ext4_warning() instead of ext4_msg()?
- Ted
next prev parent reply other threads:[~2013-01-24 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 16:30 [PATCH 1/2] ext4: call WARN_ON after the debug message Lukas Czerner
2013-01-24 16:30 ` [PATCH 2/2] ext4: remove unused variable flags Lukas Czerner
2013-01-24 16:46 ` gnehzuil.liu
2013-01-24 16:44 ` [PATCH 1/2] ext4: call WARN_ON after the debug message gnehzuil.liu
2013-01-24 19:54 ` Theodore Ts'o [this message]
2013-01-25 9:22 ` Lukáš Czerner
2013-01-25 15:09 ` Theodore Ts'o
2013-01-25 15:14 ` Lukáš Czerner
2013-01-26 1:00 ` Dave Chinner
2013-01-28 7:10 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124195458.GD9477@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.